Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

December 4th, 2023 Community Meeting #179

Closed
SaschaSchwarze0 opened this issue Dec 2, 2023 · 2 comments
Closed

December 4th, 2023 Community Meeting #179

SaschaSchwarze0 opened this issue Dec 2, 2023 · 2 comments

Comments

@SaschaSchwarze0
Copy link
Member

  • Please add a topic in this thread and add a link to the GitHub issue associated with the topic.
  • Please make sure you give folks enough time to review/discuss the topic offline on GitHub before coming into the meeting
  • (optional) Paste the image of an animal 😸
@SaschaSchwarze0
Copy link
Member Author

Follow-up from last week. This makes the url field in a Git source mandatory: shipwright-io/build#1441.

We should imo also change a Build to have .spec.source as optional. In an alpha Build, it was possible to define an empty object:

kind: Build
spec:
  source: {}

The semantic of this is that the Build has no source. The resulting pod simply has no source step and is functional. This is for scenarios where a Build strategy does not need any source, such as when just doing a rebase.

It would be nice if in the Beta API, the whole source object could be omitted.

@qu1queee
Copy link
Contributor

qu1queee commented Dec 4, 2023

Meeting minutes:

  • We discuss on the pod status showing Not Ready when listing it. We conclude that this is a normal behaviour(due to the nature of Tekton), and that is not a proper Pod state.
  • We discussed on the meaning of adding changes on the Beta API. For now, we conclude on gathering more data in terms of what we need to change, best practices for changes, and discuss again during next week meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants