Skip to content

Commit

Permalink
Fix signing of released image
Browse files Browse the repository at this point in the history
In 0b91c10, the CSV stored in git was altered to include the `ko://`
image reference. The real image reference is generated at build time,
and its "resolved" CSV is stored in an ignored directory. This
unfortunately broke the release GitHub action, which greps the in-tree
CSV fo images to sign.

This updates the release action to look at the "resolved" CSV in the
`_output/olm` directory when searching for images to sign. This also
updates cosign-installer to v2.3.0.
  • Loading branch information
adambkaplan committed Jun 3, 2022
1 parent 21d6eda commit 300b8a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- uses: actions/setup-go@v2
with:
go-version: 1.18.x
- uses: sigstore/cosign-installer@v1.2.0
- uses: sigstore/cosign-installer@v2.3.0
- name: Build Release Images
env:
REGISTRY_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -44,7 +44,7 @@ jobs:
# OIDC.
COSIGN_EXPERIMENTAL: "true"
run: |
grep -o "ghcr.io[^\"]*" "${GITHUB_WORKSPACE}/bundle/manifests/shipwright-operator.clusterserviceversion.yaml" | xargs cosign sign \
grep -o "ghcr.io[^\"]*" "${GITHUB_WORKSPACE}/_output/olm/bundle/manifests/shipwright-operator.clusterserviceversion.yaml" | uniq | xargs -n 1 cosign sign \
-a sha=${{ github.sha }} \
-a run_id=${{ github.run_id }} \
-a run_attempt=${{ github.run_attempt }}
Expand Down

0 comments on commit 300b8a0

Please sign in to comment.