Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate processes to do data fetching #197

Open
alichtman opened this issue Sep 25, 2018 · 4 comments
Open

Use separate processes to do data fetching #197

alichtman opened this issue Sep 25, 2018 · 4 comments

Comments

@alichtman
Copy link
Collaborator

It's really annoying when the interface thread blocks because it's executing a shell command.

@shobrook
Copy link
Owner

shobrook commented Nov 7, 2018

Our interim solution for this is just upping the refresh interval to a minute instead of every couple of seconds, so the user gets blocked less frequently.

@shobrook
Copy link
Owner

shobrook commented Nov 7, 2018

If a solution for this can't be found, I can think of two alternatives to spawning child processes:

  1. We have the user host a local server that the app can make requests to and get the data that way
  2. Turn off auto-refreshing and instead add an option to the menubar for the user to refresh the dashboard, and when clicked, a loading modal can pop-up notifying the user that the app is refreshing and that it may take a while

I personally prefer the second over the first because while manual refreshing costs the user some time and functionality, spinning up a server every time you want to use BitVision would be a lot more annoying. Clearly the best long-term solution would be to rewrite this entire app in either Python or Node to avoid cross-language execution in the first place, but neither of us have time to do that.

@shobrook shobrook modified the milestones: Release, v2 Nov 7, 2018
@shobrook
Copy link
Owner

shobrook commented Nov 7, 2018

@alichtman and I agreed and are going with option 2 for the alpha.

@alichtman alichtman modified the milestones: v2, Release Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants