Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FMLE-compatible sequences(releaseStream/FCPublish) #1393

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Support FMLE-compatible sequences(releaseStream/FCPublish) #1393

merged 1 commit into from
Mar 24, 2024
+14 −9

Conversation

shogo4405
Copy link
Owner

Description & motivation

  • refs Add releaseStream support and fix FCPublish call order #1391
  • I've added support for FMLE-compatible sequences. It seems that previously, we were not calling releaseStream and had the wrong order for FCPublish.
    • These are not part of the RTMP specification and are provided as RCP features of FMS. It's unclear whether server-side implementations in modern times also have business logic implemented as stubs for these functionalities.

I anticipate usage like this: Please set stream.fcPublishName before calling RTMPConnection.connect.

stream = RTMPStream(connection, “ingest-stream-name”)
stream.fcPublishName = “ingest-stream-name”
stream.publish(stream.fcPublishName)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots:

shogo4405
shogo4405 commented Mar 22, 2024
View reviewed changes
Sources/RTMP/RTMPConnection.swift
@@ -3,6 +3,8 @@ import Foundation

/// The RTMPResponder class provides to use handle RTMPConnection's callback.
open class RTMPResponder {
static let empty = RTMPResponder(result: { _ in })
Copy link
Owner Author

@shogo4405 shogo4405 Mar 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ The 'stat' is the require reason api. Please check privacy manifest files.

@shogo4405 shogo4405 force-pushed the feature/compatible-fmle branch from d7d6919 to 3052fce Compare March 22, 2024 05:51
@shogo4405 shogo4405 marked this pull request as ready for review March 22, 2024 05:59
@shogo4405 shogo4405 added this to the 1.7.5 milestone Mar 22, 2024
@shogo4405 shogo4405 merged commit 04c5418 into main Mar 24, 2024
2 checks passed
@shogo4405 shogo4405 deleted the feature/compatible-fmle branch March 24, 2024 05:26
This was referenced Mar 24, 2024
Closed
Merged
@shogo4405 shogo4405 mentioned this pull request Apr 8, 2024
Merged
1 task
@levs42 levs42 mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.5
Development

Successfully merging this pull request may close these issues.
1 participant
@shogo4405