Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMEMO indication #6

Open
bugtrapper opened this issue Jul 13, 2017 · 4 comments · May be fixed by #19
Open

OMEMO indication #6

bugtrapper opened this issue Jul 13, 2017 · 4 comments · May be fixed by #19

Comments

@bugtrapper
Copy link

With the build from June 7th, I don't get the (OMEMO) in the window title like my conversation partner does with Pidgin when we're in an OMEMO-encrypted conversation.
Is that possible with Adium at all?

@shtrom
Copy link
Owner

shtrom commented Jul 13, 2017

Yup, same thing here. Don't know if it's possible. Adium needs some wrapping around the libpurple plugins, and doesn't seem to be honouring the window title without more work.

Lurch does it in lurch_topic_update_im https://github.com/shtrom/libpurple-lurch/blob/macos-build/src/lurch.c#L2171, amongst others, called from lurch_conv_created_cb.

Ultimately, it uses purple_conversation_set_title https://github.com/shtrom/libpurple-lurch/blob/macos-build/src/lurch.c#L2184-L2186 . We'll need to work out how Adium handles this call, if at all.

@gkdr
Copy link

gkdr commented Jul 17, 2017

Well, this is very hacky anyway since Pidgin keeps changing the title every time a title gains or loses focus so I constantly have to check for a change event and change it back.
I basically only check if at least one session exists, maybe there is a more elegant way to do it in Adium?

@shtrom
Copy link
Owner

shtrom commented Jul 18, 2017

Yeah, I wonder whether we should just have the plugin write more info into the chat---say, when it starts, or once a day---in the same way as it flag unencrypted messages. This would be a change in Lurch, but it might work out.

@shtrom
Copy link
Owner

shtrom commented Feb 11, 2020

I think gkdr/lurch#129 should fix this issue. Need to test with that PR merged in a test branch.

shtrom added a commit that referenced this issue Feb 11, 2020
@shtrom shtrom linked a pull request Feb 11, 2020 that will close this issue
shtrom added a commit that referenced this issue Feb 11, 2020
shtrom added a commit that referenced this issue Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants