Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling .render() with no data causes TypeError to be thrown #438

Open
abirmingham opened this issue Jun 12, 2014 · 1 comment
Open

Calling .render() with no data causes TypeError to be thrown #438

abirmingham opened this issue Jun 12, 2014 · 1 comment

Comments

@abirmingham
Copy link

On latest master.

Steps to Reproduce:

  1. Create graph with data
  2. Update graph to remove data (e.g. graph.series.slice())
  3. Call graph.render()
  4. See the following issue:
TypeError: Cannot read property 'length' of undefined
    at Function.d3_layout_stackOffsetZero (http://localhost/media/gui/lib/d3.js:6637:28)
    at stack (http://localhost/media/gui/lib/d3.js:6518:28)
    at stackData (http://localhost/media/gui/lib/rickshaw.js:571:18)
    at render (http://localhost/media/gui/lib/rickshaw.js:516:26)

Here are some relevant issues:
#226 #122 #244

@abirmingham
Copy link
Author

Added a naive PR for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant