New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooling] Improve imports in antlr-worker.js #800

Open

pcnfernando opened this issue Dec 17, 2019 · 0 comments

Contributor

pcnfernando commented Dec 17, 2019

Description:
At the moment we have imports defined in antlr-worker.js which will be imported for each initialization of antlr-worker which will be called for opening of each tab.
https://github.com/siddhi-io/distribution/blob/master/tooling/components/io.siddhi.distribution.editor.core/src/main/resources/web/editor/js/source-editor/antlr-worker.js#L16

This in-turn causes app validation to delay until these scripts are downloaded.

We can improve it to import needed scripts as in https://github.com/siddhi-io/distribution/blob/master/tooling/components/io.siddhi.distribution.editor.core/src/main/resources/web/editor/js/source-editor/editor.js#L8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment