Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment config read as YAML instead of a string #32

Open
BuddhiWathsala opened this issue Jul 3, 2019 · 1 comment
Open

Deployment config read as YAML instead of a string #32

BuddhiWathsala opened this issue Jul 3, 2019 · 1 comment

Comments

@BuddhiWathsala
Copy link
Contributor

BuddhiWathsala commented Jul 3, 2019

Description:
Currently, the custom object of siddhi operator reads the configurations that need to change at the siddhi runner level using a string as below.

siddhi.runner.configs: |-
    state.persistence:
      enabled: true
      intervalInMin: 1
      revisionsToKeep: 2
      persistenceStore: io.siddhi.distribution.core.persistence.FileSystemPersistenceStore
      config:
        location: siddhi-app-persistence

It is much better to have direct YAML reading instead of this string. In order to enable that YAML reading, we have to read arbitrary YAML in operator level.

In golang, we normally read arbitrary JSON objects using structures like below.

map[string]interface{}

But because of this issue in operator sdk, we are having a problem of reading an arbitrary YAML.

Suggested Labels:
type/improvement

Related Issues:
operator-framework/operator-sdk#1624

@mohanvive
Copy link
Contributor

Check: Read the yaml file as a map and convert it to a YAML string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants