Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): removing the need for meta-inf file #15

Closed

Conversation

ryanandersleech
Copy link

fix(): removing the need for meta-inf file and making everything go through module.yml

fix(): removing the need for meta-inf file and making everything go through module.yml
@sieadev sieadev self-requested a review November 27, 2024 12:49
@sieadev sieadev marked this pull request as draft November 27, 2024 13:16
Copy link
Member

@sieadev sieadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so a few things.

Your module.yml reader throws exceptions because some values in the module.yml (e.g., name, version, description, etc.) are not present in your class. Ensure the class matches all keys expected in the module.yml. For reference, here’s an example of a module.yml file:

name: Example
version: '${project.version}'
description: Example description
authors: [John Doe]
priority: DEFAULT
mainClass: com.example.Example

Nevertheless, the reader should not throw exceptions for unexpected or extra keys. Instead, it should gracefully ignore them to prevent breaking the loading process.

Furthermore, your ModuleConfig class should not have any setters. All values in the class should be immutable.

@sieadev sieadev closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants