From f6b22c80ce335362c25775c03b65c3259bc8dac1 Mon Sep 17 00:00:00 2001 From: Sumanth K B Date: Thu, 28 Sep 2023 09:56:37 +0530 Subject: [PATCH] PR Comments --- .../NugetDevDependencyParser.cs | 2 +- src/LCT.PackageIdentifier/NugetProcessor.cs | 2 +- .../appSettingsSW360IntegrationTest.json | 12 ++++++------ src/UnitTestUtilities/appsettingsUnitTest.json | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/LCT.PackageIdentifier/NugetDevDependencyParser.cs b/src/LCT.PackageIdentifier/NugetDevDependencyParser.cs index 4ba9c63a..386ffb68 100644 --- a/src/LCT.PackageIdentifier/NugetDevDependencyParser.cs +++ b/src/LCT.PackageIdentifier/NugetDevDependencyParser.cs @@ -44,7 +44,7 @@ public static NugetDevDependencyParser Instance } } - public static List Parse(string configFile) + public List Parse(string configFile) { List containerList = new(); diff --git a/src/LCT.PackageIdentifier/NugetProcessor.cs b/src/LCT.PackageIdentifier/NugetProcessor.cs index f4ba45ae..3a800b48 100644 --- a/src/LCT.PackageIdentifier/NugetProcessor.cs +++ b/src/LCT.PackageIdentifier/NugetProcessor.cs @@ -633,7 +633,7 @@ private static string ReferenceTagDetailsForPackageReference(XmlNode childNode, private static List ParseAssetFile(string configFile) { NugetDevDependencyParser nugetDevDependencyParser = NugetDevDependencyParser.Instance; - List containers = NugetDevDependencyParser.Parse(configFile); + List containers = nugetDevDependencyParser.Parse(configFile); return ConvertContainerAsNugetPackage(containers, configFile); } diff --git a/src/TestUtilities/appSettingsSW360IntegrationTest.json b/src/TestUtilities/appSettingsSW360IntegrationTest.json index 3ad58a06..5ea55547 100644 --- a/src/TestUtilities/appSettingsSW360IntegrationTest.json +++ b/src/TestUtilities/appSettingsSW360IntegrationTest.json @@ -1,15 +1,15 @@ { - "FossologyURL": "http://md2pdvnc.ad001.siemens.net:8096", + "FossologyURL": "", "RemoveDevDependency": true, "SW360AuthTokenType": "Token", "SW360ProjectID": "0d0e23f6bccb4072be91b5a3462414ad", "SW360ProjectName": "Test", - "SW360URL": "http://md2pdvnc.ad001.siemens.net:8095", + "SW360URL": "", "JfrogNugetDestRepoName": "nuget-test", "JfrogNpmDestRepoName": "npm-test", "JfrogMavenDestRepoName": "maven-test", - "ArtifactoryUploadApiKey": "AKCp8nyNrX7MxdivMy7ka2CwdLfQERMcbJ4Y6icHoQJQA6ZMjYJk4nLTrWs5TCeWXmzz8ya94", - "ArtifactoryUploadUser": "karthika.g@siemens.com", - "JfrogApi": "https://siemens.jfrog.io/artifactory", - "SW360AuthTokenValue": "mlhPtOTmz7cAG7deyyDh" + "ArtifactoryUploadUser": "", + "ArtifactoryUploadApiKey": "", + "JfrogApi": "", + "SW360AuthTokenValue": "" } diff --git a/src/UnitTestUtilities/appsettingsUnitTest.json b/src/UnitTestUtilities/appsettingsUnitTest.json index df660243..4922a603 100644 --- a/src/UnitTestUtilities/appsettingsUnitTest.json +++ b/src/UnitTestUtilities/appsettingsUnitTest.json @@ -1,5 +1,5 @@ { "SW360URL": "http://localhost:8090", "FossologyURL": "http://localhost:8091", - "JFrogURL": "https://siemens.jfrog.io/artifactory" + "JFrogURL": "" } \ No newline at end of file