Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
danielleroux committed May 15, 2024
1 parent ec977c2 commit 8087b20
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { defineCustomElements } from '@siemens/ix-icons/loader';
})();
```

### Angular / Web Component
### Angular / Web Components

```html
<ix-icon name="rocket"></ix-icon>
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/meta-tag.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function getV3PreviewMetaContent() {
}

/**
* Provide custom svg path for icons
* Provide custom SVG path for icons
*
* <meta name="ix-icons:path" content="/build/svg" />
*/
Expand Down
8 changes: 4 additions & 4 deletions src/components/icon/resolveIcon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ declare global {
}
}

let fetchCatch: Map<string, string>;
let fetchCache: Map<string, string>;
const requests = new Map<string, Promise<string>>();
let parser = null;

Expand Down Expand Up @@ -43,11 +43,11 @@ export const getIconCacheMap = (): Map<string, string> => {
return new Map();
}

if (!fetchCatch) {
if (!fetchCache) {
window.IxIcons = window.IxIcons || {};
fetchCatch = window.IxIcons.map = window.IxIcons.map || new Map();
fetchCache = window.IxIcons.map = window.IxIcons.map || new Map();
}
return fetchCatch;
return fetchCache;
};

export const isSvgDataUrl = (url: string) => {
Expand Down

0 comments on commit 8087b20

Please sign in to comment.