fix(core/select): set value before triggering event (#1401)

siemens · Jul 29, 2024 · 1b4da95 · 1b4da95
1 parent 5343eed
commit 1b4da95
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/fuzzy-countries-jam.md b/.changeset/fuzzy-countries-jam.md
@@ -0,0 +1,5 @@
+---
+"@siemens/ix": patch
+---
+
+fix(core/select): set value before triggering event
diff --git a/packages/core/src/components/select/select.tsx b/packages/core/src/components/select/select.tsx
@@ -254,14 +254,16 @@ export class Select {
   }
 
   private itemClick(newId: string) {
+    const oldValue = this.value;
     const value = this.toggleValue(newId);
+    this.value = value;
     const defaultPrevented = this.emitValueChange(value);
 
     if (defaultPrevented) {
+      this.value = oldValue;
       return;
     }
 
-    this.value = value;
     this.updateSelection();
   }