fix: adapt pipelines

siemens · Apr 3, 2024 · 79001cb · 79001cb
1 parent 1edfcb8
commit 79001cb
Show file tree

Hide file tree

Showing 2 changed files with 69 additions and 26 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -67,12 +67,33 @@ jobs:
             ./packages/aggrid/playwright-report/
           retention-days: 1
 
+  visual-testing-echarts:
+    needs: [build]
+    timeout-minutes: 10
+    runs-on: ubuntu-latest
+    container:
+      image: mcr.microsoft.com/playwright:v1.39.0-jammy
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/actions/turbo
+
+      - name: Visual Regression
+        run: pnpm run visual-regression --cache-dir=.turbo --filter @siemens/ix-echarts
+
+      - uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: echarts-html-report--attempt-${{ github.run_attempt }}
+          path: |
+            ./packages/echarts/playwright-report/
+          retention-days: 1
+
   merge-core-reports:
-      if: failure()
-      needs: [visual-testing-core]
+    if: failure()
+    needs: [visual-testing-core]
 
-      runs-on: ubuntu-latest
-      steps:
+    runs-on: ubuntu-latest
+    steps:
       - uses: actions/checkout@v3
       - uses: ./.github/workflows/actions/turbo
 

diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -20,24 +20,24 @@ jobs:
       aggrid_any_changed: ${{ steps.changes.outputs.aggrid_any_changed }}
       docs_any_changed: ${{ steps.changes.outputs.docs_any_changed }}
     steps:
-    - uses: actions/checkout@v3
-    - name: Track changes between commits
-      id: changes
-      uses: tj-actions/changed-files@v43
-      with:
-        files_yaml: |
-          core:
-            - packages/core/**
-          angular:
-            - packages/angular/**
-          aggrid:
-            - packages/aggrid/**
-          docs:
-            - packages/documentation/**
-            - packages/html-test-app/**
-            - packages/angular-test-app/**
-            - packages/react-test-app/**
-            - packages/vue-test-app/**
+      - uses: actions/checkout@v3
+      - name: Track changes between commits
+        id: changes
+        uses: tj-actions/changed-files@v43
+        with:
+          files_yaml: |
+            core:
+              - packages/core/**
+            angular:
+              - packages/angular/**
+            aggrid:
+              - packages/aggrid/**
+            docs:
+              - packages/documentation/**
+              - packages/html-test-app/**
+              - packages/angular-test-app/**
+              - packages/react-test-app/**
+              - packages/vue-test-app/**
 
   build:
     needs: changes
@@ -102,11 +102,33 @@ jobs:
             ./packages/aggrid/playwright-report/
           retention-days: 1
 
+  visual-testing-echarts:
+    if: ${{ needs.changes.outputs.core_any_changed == 'true' || needs.changes.outputs.echarts_any_changed == 'true' }}
+    needs: [build, changes]
+    timeout-minutes: 10
+    runs-on: ubuntu-latest
+    container:
+      image: mcr.microsoft.com/playwright:v1.39.0-jammy
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/actions/turbo
+
+      - name: Visual Regression
+        run: pnpm run visual-regression --cache-dir=.turbo --filter @siemens/ix-echarts
+
+      - uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: echarts-html-report--attempt-${{ github.run_attempt }}
+          path: |
+            ./packages/echarts/playwright-report/
+          retention-days: 1
+
   merge-core-reports:
-      if: failure()
-      needs: [visual-testing-core]
-      runs-on: ubuntu-latest
-      steps:
+    if: failure()
+    needs: [visual-testing-core]
+    runs-on: ubuntu-latest
+    steps:
       - uses: actions/checkout@v3
       - uses: ./.github/workflows/actions/turbo