Skip to content

Commit

Permalink
fix(blind): provided ellipsis for blind header (#1186)
Browse files Browse the repository at this point in the history
Co-authored-by: Demirci <[email protected]>
Co-authored-by: Daniel Leroux <[email protected]>
  • Loading branch information
3 people authored Apr 3, 2024
1 parent 96732fb commit b7a56fe
Show file tree
Hide file tree
Showing 21 changed files with 25 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .changeset/curly-singers-complain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@siemens/ix": patch
---

fix(core/blind): show ellipsis if text overflows
14 changes: 6 additions & 8 deletions packages/core/src/components/blind/blind.scss
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@
overflow: hidden;

.blind-header-wrapper {
display: block;
position: relative;
width: 100%;
min-height: 3rem;
height: 3rem;
overflow: hidden;
Expand All @@ -97,8 +95,7 @@
position: relative;
align-items: center;
flex-grow: 1;
flex-shrink: 0;
margin-right: 1rem;
margin-right: 0.5rem;
}

.blind-header {
Expand Down Expand Up @@ -135,15 +132,15 @@

.blind-header-title-row {
display: flex;
flex-grow: 1;
width: 100%;
overflow: hidden;
}

.blind-header-title-col {
flex-grow: 1;
flex-basis: 0;
display: inline-flex;
align-items: center;
min-width: 0;
width: calc(100% - 1rem);
overflow: hidden;
}

.blind-header-title-col:not(:first-of-type) {
Expand Down Expand Up @@ -194,6 +191,7 @@

.header-actions {
pointer-events: all;
margin-left: auto;
}
}

Expand Down
14 changes: 14 additions & 0 deletions packages/core/src/tests/blind/basic/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,20 @@
<ix-blind icon="bulb" variant="primary" label="primary" sublabel="sublabel">
<div>Primary content</div>
</ix-blind>
<ix-blind
icon="warning"
variant="warning"
label="A long asset name that does not fit to blind header"
subLabel="subLabel A long asset name that does not fit"
style="width: 300px"
>
<ix-icon-button
id="context-menu"
slot="header-actions"
ghost
icon="context-menu"
></ix-icon-button>
</ix-blind>
<script src="http://127.0.0.1:8080/scripts/e2e/load-e2e-runtime.js"></script>
</body>
</html>
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.

0 comments on commit b7a56fe

Please sign in to comment.