From c23c9ce530e27d2a11e98b3d090acf144b930445 Mon Sep 17 00:00:00 2001 From: Lukas Maurer Date: Thu, 12 Sep 2024 10:44:21 +0200 Subject: [PATCH 1/9] docs(mobile): create category and split into subsections (#1463) --- .../{mobile.md => mobile/mobile-app-dev.md} | 38 +------------------ .../documentation/docs/mobile/mobile-ux.md | 33 ++++++++++++++++ packages/documentation/sidebars.ts | 14 +++++-- 3 files changed, 45 insertions(+), 40 deletions(-) rename packages/documentation/docs/{mobile.md => mobile/mobile-app-dev.md} (77%) create mode 100644 packages/documentation/docs/mobile/mobile-ux.md diff --git a/packages/documentation/docs/mobile.md b/packages/documentation/docs/mobile/mobile-app-dev.md similarity index 77% rename from packages/documentation/docs/mobile.md rename to packages/documentation/docs/mobile/mobile-app-dev.md index f68e03c9ed..21a1add5e8 100644 --- a/packages/documentation/docs/mobile.md +++ b/packages/documentation/docs/mobile/mobile-app-dev.md @@ -43,7 +43,7 @@ There are different ways to create applications for mobile devices: - **Native apps** are tailored for a particular platform like iOS or Android and usually need to be developed in a specific way for every target platform separately. - **Hybrid apps** are based on web technologies while targeting multiple platforms using a single codebase. -Optimize your web application for mobile devices without any significant technological changes to provide a seamless User Experience across devices and screen sizes (read more about responsive and adaptive design [here](#user-experience-considerations)). +Optimize your web application for mobile devices without any significant technological changes to provide a seamless User Experience across devices and screen sizes (read more about responsive and adaptive design [here](mobile-ux.md)). ### Hybrid app development @@ -146,7 +146,7 @@ Use the defined variables to ensure that the pages of your application displayin ### Application frame layout -By default, the [Application Frame](./controls/application-frame/application.md) provides three default layouts (`sm`, `md`, `lg`) that are automatically applied depending on the size of the screen. +By default, the [Application Frame](./../controls/application-frame/application.md) provides three default layouts (`sm`, `md`, `lg`) that are automatically applied depending on the size of the screen. If you intend to implement an app for both phones and tablets (e.g. iPhone and iPad), it may be necessary to configure the layouts which the application frame can pick from. @@ -184,37 +184,3 @@ const Application = () => { ); }; ``` - -## User experience considerations - -### Responsive and adaptive design - -Industrial Experience components handle various viewport sizes out-of-the-box. When building a page layout, consider small screens in portrait and landscape mode in an early stage during the design phase. - -Depending on the importance of a mobile-optimized UI, decide on a responsive or adaptive design approach: - -- **Responsive design**: The layout adapts to the viewport size by rearranging or hiding components. We recommend this approach for desktop-first applications. -- **Adaptive design**: There is a separate page layout for a specific breakpoint. We recommend this approach for applications with a strong focus on mobile. - -If feasible, we recommend adaptive design since it offers more control over the layout and a more optimized user experience on mobile devices. However, it requires more effort to maintain different layouts. Independently from the design approach, there are different approaches to achieve a mobile-friendly experience: - -- Adjust the page layout (e.g. a column-based layout transforms into a row-based layout) -- Restructure the content (e.g. prioritize information or components differently) -- Hide information or entire components (e.g. less important information or components) - -### Interaction - -Users interact with mobile devices primarily through touch input. Our web components respond to touch events out-of-the-box. - -For your specific use cases, it might be necessary to implement custom event listeners for touch interactions. In addition, touch devices offer the possibility to use gestures like swiping, pinching or tapping. - -### Device-specific features - -Some devices have unique characteristics that need to be considered when designing and developing an app: - -- Display "notch" -- System bars -- Rounded corners -- Different screen sizes and resolutions - -When you design and develop an app, we recommend to define target devices. Consider the specific features of the devices in your design and development process, so that all relevant parts of the user interface are visible and accessible. Use the [safe areas](#define-safe-areas) to ensure that the content is displayed correctly. diff --git a/packages/documentation/docs/mobile/mobile-ux.md b/packages/documentation/docs/mobile/mobile-ux.md new file mode 100644 index 0000000000..0eb917fb23 --- /dev/null +++ b/packages/documentation/docs/mobile/mobile-ux.md @@ -0,0 +1,33 @@ +# User experience considerations + +## Responsive and adaptive design + +Industrial Experience components handle various viewport sizes out-of-the-box. When building a page layout, consider small screens in portrait and landscape mode in an early stage during the design phase. + +Depending on the importance of a mobile-optimized UI, decide on a responsive or adaptive design approach: + +- **Responsive design**: The layout adapts to the viewport size by rearranging or hiding components. We recommend this approach for desktop-first applications. +- **Adaptive design**: There is a separate page layout for a specific breakpoint. We recommend this approach for applications with a strong focus on mobile. + +If feasible, we recommend adaptive design since it offers more control over the layout and a more optimized user experience on mobile devices. However, it requires more effort to maintain different layouts. Independently from the design approach, there are different approaches to achieve a mobile-friendly experience: + +- Adjust the page layout (e.g. a column-based layout transforms into a row-based layout) +- Restructure the content (e.g. prioritize information or components differently) +- Hide information or entire components (e.g. less important information or components) + +## Interaction + +Users interact with mobile devices primarily through touch input. Our web components respond to touch events out-of-the-box. + +For your specific use cases, it might be necessary to implement custom event listeners for touch interactions. In addition, touch devices offer the possibility to use gestures like swiping, pinching or tapping. + +## Device-specific features + +Some devices have unique characteristics that need to be considered when designing and developing an app: + +- Display "notch" +- System bars +- Rounded corners +- Different screen sizes and resolutions + +When you design and develop an app, we recommend to define target devices. Consider the specific features of the devices in your design and development process, so that all relevant parts of the user interface are visible and accessible. Use the [safe areas](#define-safe-areas) to ensure that the content is displayed correctly. diff --git a/packages/documentation/sidebars.ts b/packages/documentation/sidebars.ts index b2dcaa3cec..3416098730 100644 --- a/packages/documentation/sidebars.ts +++ b/packages/documentation/sidebars.ts @@ -108,10 +108,6 @@ const sidebars: SidebarsConfig = { }, ], }, - { - type: 'doc', - id: 'mobile', - }, ], }, { @@ -144,6 +140,16 @@ const sidebars: SidebarsConfig = { }, ], }, + { + type: 'category', + label: 'Mobile experience', + items: [ + { + type: 'autogenerated', + dirName: 'mobile', + }, + ] + }, { type: 'category', label: 'Migration', From dba2c852c46eff3d778d0b9ab3634ca8284d363f Mon Sep 17 00:00:00 2001 From: matthiashader <144090716+matthiashader@users.noreply.github.com> Date: Fri, 13 Sep 2024 13:29:41 +0200 Subject: [PATCH 2/9] fix(core/select): allow enter selection (#1456) Co-authored-by: AndreasBerliner <41509230+AndreasBerliner@users.noreply.github.com> --- .../core/src/components/select/select.tsx | 48 +++++++--------- .../src/components/select/test/select.ct.ts | 57 +++++++++++++++++++ 2 files changed, 78 insertions(+), 27 deletions(-) diff --git a/packages/core/src/components/select/select.tsx b/packages/core/src/components/select/select.tsx index c007184793..9dd32470e0 100644 --- a/packages/core/src/components/select/select.tsx +++ b/packages/core/src/components/select/select.tsx @@ -330,13 +330,12 @@ export class Select { this.selectedLabels = this.selectedItems.map((item) => item.label); - if (this.isSingleMode && this.selectedLabels?.length) { + if (this.selectedLabels?.length && this.isSingleMode) { this.inputValue = this.selectedLabels[0]; - this.inputRef && (this.inputRef.value = this.inputValue); - return; + } else { + this.inputValue = ''; } - - this.inputValue = null; + this.inputRef && (this.inputRef.value = this.inputValue); } private emitValueChange(value: string | string[]) { @@ -414,7 +413,7 @@ export class Select { } if (event.code === 'Enter' || event.code === 'NumpadEnter') { - await this.onEnterNavigation(); + await this.onEnterNavigation(event.target as HTMLIxSelectItemElement); } if (event.code === 'Escape') { @@ -422,31 +421,27 @@ export class Select { } } - private async onEnterNavigation() { + private async onEnterNavigation( + el: HTMLIxSelectItemElement | HTMLInputElement + ) { if (this.isMultipleMode) { return; } - let item: HTMLIxSelectItemElement; - - if (this.editable && !this.itemExists(this.inputFilterText)) { - const defaultPrevented = this.emitAddItem(this.inputFilterText); - if (defaultPrevented) { - return; + if ( + !this.itemExists(this.inputFilterText.trim()) && + !this.itemExists((el as HTMLIxSelectItemElement)?.label) + ) { + if (this.editable) { + const defaultPrevented = this.emitAddItem(this.inputFilterText.trim()); + if (defaultPrevented) { + return; + } } - - item = this.items[this.items.length - 1]; - } - - if (item) { - item.onItemClick(); } - await this.dropdownRef?.updatePosition(); - - if (this.isSingleMode && !this.editable) { - this.dropdownShow = false; - } + this.dropdownShow = false; + this.updateSelection(); } private async onArrowNavigation( @@ -770,9 +765,8 @@ export class Select { label={this.inputFilterText} onItemClick={(e) => { e.preventDefault(); - if (this.emitAddItem(this.inputFilterText)) { - e.stopPropagation(); - } + e.stopPropagation(); + this.emitAddItem(this.inputFilterText); }} onFocus={() => (this.navigationItem = this.addItemRef)} ref={(ref) => { diff --git a/packages/core/src/components/select/test/select.ct.ts b/packages/core/src/components/select/test/select.ct.ts index dac4a04e46..d5e01d209c 100644 --- a/packages/core/src/components/select/test/select.ct.ts +++ b/packages/core/src/components/select/test/select.ct.ts @@ -264,6 +264,55 @@ test('type in a novel item name in editable mode, click outside and reopen the s await expect(page.getByRole('button', { name: 'Item 3' })).toBeVisible(); }); +test('type in a novel item name and click outside', async ({ mount, page }) => { + await mount(` + + Test + Test + Test + + outside + `); + + const selectElement = page.locator('ix-select'); + await expect(selectElement).toHaveClass(/hydrated/); + + await page.locator('[data-select-dropdown]').click(); + await page.getByTestId('input').fill('test'); + + await page.keyboard.press('Enter'); + const inputValue = await page.getByTestId('input').inputValue(); + + expect(inputValue).toBe('Item 2'); +}); + +test('type in a novel item name in multiple mode, click outside', async ({ + mount, + page, +}) => { + await mount(` + + Test + Test + Test + + outside + `); + + const selectElement = page.locator('ix-select'); + const btnElement = page.locator('ix-button'); + await expect(selectElement).toHaveClass(/hydrated/); + await expect(btnElement).toBeVisible(); + + await page.locator('[data-select-dropdown]').click(); + await page.getByTestId('input').fill('test'); + + await btnElement.click(); + const inputValue = await page.getByTestId('input').inputValue(); + + expect(inputValue).toBe(''); +}); + test('pass object as value and check if it is selectable', async ({ mount, page, @@ -343,6 +392,7 @@ test.describe('arrow key navigation', () => { await input.focus(); await input.fill('I'); await page.keyboard.down('Enter'); + await page.locator('ix-icon-button').click(); await page.waitForSelector('.checkmark'); await page.keyboard.down('ArrowDown'); @@ -362,6 +412,7 @@ test.describe('arrow key navigation', () => { await input.focus(); await input.fill('I'); await page.keyboard.down('Enter'); + await page.locator('ix-icon-button').click(); await page.waitForSelector('.checkmark'); await page.keyboard.down('ArrowDown'); @@ -410,6 +461,7 @@ test.describe('arrow key navigation', () => { await input.focus(); await input.fill('Item 2'); await page.keyboard.down('Enter'); + await page.locator('ix-icon-button').click(); await page.waitForSelector('.checkmark'); await input.clear(); @@ -491,6 +543,7 @@ test.describe('arrow key navigation', () => { await input.focus(); await input.fill('Item 1'); await page.keyboard.press('Enter'); + await page.locator('ix-icon-button').click(); await page.waitForSelector('.checkmark'); await input.clear(); @@ -525,6 +578,7 @@ test.describe('arrow key navigation', () => { await input.focus(); await input.fill('I'); await page.keyboard.down('Enter'); + await page.locator('ix-icon-button').click(); await page.waitForSelector('.checkmark'); await page.keyboard.down('ArrowDown'); @@ -578,6 +632,7 @@ test.describe('arrow key navigation', () => { await input.focus(); await input.fill('Item 1'); await page.keyboard.press('Enter'); + await page.locator('ix-icon-button').click(); await page.waitForSelector('.checkmark'); await input.clear(); @@ -610,6 +665,7 @@ test.describe('arrow key navigation', () => { await input.focus(); await input.fill('Item 2'); await page.keyboard.press('Enter'); + await page.locator('ix-icon-button').click(); await page.locator('input').clear(); await page.keyboard.down('ArrowDown'); @@ -651,6 +707,7 @@ test.describe('arrow key navigation', () => { await input.focus(); await input.fill('Item 1'); await page.keyboard.press('Enter'); + await page.locator('ix-icon-button').click(); await page.waitForSelector('.checkmark'); await input.clear(); From 2401b2ee27d4975cbe77bab2c6300abc791f4310 Mon Sep 17 00:00:00 2001 From: Lukas Maurer Date: Fri, 13 Sep 2024 13:51:38 +0200 Subject: [PATCH 3/9] =?UTF-8?q?fix(core/tree):=20prevent=20hyperlist=20fro?= =?UTF-8?q?m=20disposing=20dropdowns=20linked=20to=20=E2=80=A6=20(#1460)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Daniel Leroux --- .changeset/spicy-ravens-care.md | 5 ++ packages/angular/src/components.ts | 2 +- packages/core/component-doc.json | 2 +- packages/core/src/components.d.ts | 2 +- .../src/components/tree-item/tree-item.tsx | 2 +- .../core/src/components/tree/test/tree.ct.ts | 58 +++++++++++++++++++ packages/core/src/components/tree/tree.tsx | 23 ++++++-- .../src/components/Accordion/accordion.scss | 4 ++ 8 files changed, 90 insertions(+), 8 deletions(-) create mode 100644 .changeset/spicy-ravens-care.md diff --git a/.changeset/spicy-ravens-care.md b/.changeset/spicy-ravens-care.md new file mode 100644 index 0000000000..f377f150e0 --- /dev/null +++ b/.changeset/spicy-ravens-care.md @@ -0,0 +1,5 @@ +--- +"@siemens/ix": patch +--- + +fix(core/tree): prevent hyperlist from disposing dropdowns linked to tree items diff --git a/packages/angular/src/components.ts b/packages/angular/src/components.ts index 877b9a5d56..9eb6d100af 100644 --- a/packages/angular/src/components.ts +++ b/packages/angular/src/components.ts @@ -2349,7 +2349,7 @@ export declare interface IxTreeItem extends Components.IxTreeItem { */ toggle: EventEmitter>; /** - * Clicked + * Click on item not on the expand/collapse icon */ itemClick: EventEmitter>; } diff --git a/packages/core/component-doc.json b/packages/core/component-doc.json index e3e9fa69e5..b516289624 100644 --- a/packages/core/component-doc.json +++ b/packages/core/component-doc.json @@ -16582,7 +16582,7 @@ }, "cancelable": true, "composed": true, - "docs": "Clicked", + "docs": "Click on item not on the expand/collapse icon", "docsTags": [] }, { diff --git a/packages/core/src/components.d.ts b/packages/core/src/components.d.ts index 730da09e6c..03f40e0d39 100644 --- a/packages/core/src/components.d.ts +++ b/packages/core/src/components.d.ts @@ -6600,7 +6600,7 @@ declare namespace LocalJSX { */ "hasChildren"?: boolean; /** - * Clicked + * Click on item not on the expand/collapse icon */ "onItemClick"?: (event: IxTreeItemCustomEvent) => void; /** diff --git a/packages/core/src/components/tree-item/tree-item.tsx b/packages/core/src/components/tree-item/tree-item.tsx index 9886da1735..bcf829eac0 100644 --- a/packages/core/src/components/tree-item/tree-item.tsx +++ b/packages/core/src/components/tree-item/tree-item.tsx @@ -37,7 +37,7 @@ export class TreeItem { @Event() toggle!: EventEmitter; /** - * Clicked + * Click on item not on the expand/collapse icon */ @Event() itemClick!: EventEmitter; diff --git a/packages/core/src/components/tree/test/tree.ct.ts b/packages/core/src/components/tree/test/tree.ct.ts index 3df9e3d3ca..c324174492 100644 --- a/packages/core/src/components/tree/test/tree.ct.ts +++ b/packages/core/src/components/tree/test/tree.ct.ts @@ -8,6 +8,7 @@ */ import { expect, Locator, Page } from '@playwright/test'; import { test } from '@utils/test'; +import { TreeItem } from '../tree-model'; const defaultModel = { root: { @@ -171,3 +172,60 @@ test('update tree', async ({ mount, page }) => { await expect(newChildItem).toBeVisible(); await expect(newChildItem).toHaveCSS('padding-left', '32px'); }); + +test('dropdown trigger', async ({ mount, page }) => { + const tree = await initializeTree(mount, page); + + await tree.evaluate( + (t) => + ((t as HTMLIxTreeElement).renderItem = ( + _index, + item, + _dataList, + context, + update + ) => { + const el = document.createElement('ix-tree-item'); + const treeItem = item as TreeItem; + el.hasChildren = treeItem.hasChildren; + el.context = context[treeItem.id]; + el.id = `trigger-${treeItem.id}`; + + const div = document.createElement('div'); + div.style.display = 'flex'; + + const name = document.createElement('span'); + const dd = document.createElement('ix-dropdown'); + const ddItem = document.createElement('ix-dropdown-item'); + ddItem.innerHTML = 'Action 1'; + dd.trigger = `trigger-${treeItem.id}`; + + div.appendChild(name); + div.appendChild(dd); + dd.appendChild(ddItem); + + name.innerText = treeItem.id; + + el.appendChild(div); + + update((updateTreeItem) => { + name.innerText = updateTreeItem.data.name; + }); + + return el; + }) + ); + + const root = tree.locator('ix-tree-item').first(); + await root.locator('.icon-toggle-container').click(); + + const item1 = tree.locator('ix-tree-item').nth(1); + const dropdown1 = item1.locator('ix-dropdown'); + await item1.click(); + await expect(dropdown1).toBeVisible(); + + const item2 = tree.locator('ix-tree-item').nth(2); + const dropdown2 = item2.locator('ix-dropdown'); + await item2.click(); + await expect(dropdown2).toBeVisible(); +}); diff --git a/packages/core/src/components/tree/tree.tsx b/packages/core/src/components/tree/tree.tsx index ae26e665f5..0c52fd177d 100644 --- a/packages/core/src/components/tree/tree.tsx +++ b/packages/core/src/components/tree/tree.tsx @@ -27,6 +27,7 @@ import { TreeModel, UpdateCallback, } from './tree-model'; +import { dropdownController } from '../dropdown/dropdown-controller'; @Component({ tag: 'ix-tree', @@ -173,16 +174,30 @@ export class Tree { this.updatePadding(el, item); if (!this.itemClickListener.has(el)) { - const itemClickCallback = (e: Event) => { - e.preventDefault(); - e.stopPropagation(); + const itemClickCallback = (event: Event) => { + const path = event.composedPath(); + const treeIndex = path.indexOf(this.hostElement); + const treePath = path.slice(0, treeIndex); + const hasTrigger = dropdownController.pathIncludesTrigger(treePath); + + if (event.defaultPrevented) { + return; + } + + if (hasTrigger) { + return; + } + Object.values(this.context).forEach((c) => (c.isSelected = false)); const context = this.getContext(item.id); context.isSelected = true; this.setContext(item.id, context); this.nodeClicked.emit(item.id); }; - el.addEventListener('itemClick', itemClickCallback); + el.addEventListener('toggle', (event) => { + event.preventDefault(); + }); + el.addEventListener('click', itemClickCallback); this.itemClickListener.set(el, itemClickCallback); } diff --git a/packages/documentation/src/components/Accordion/accordion.scss b/packages/documentation/src/components/Accordion/accordion.scss index 5188b6247d..128eaa0dce 100644 --- a/packages/documentation/src/components/Accordion/accordion.scss +++ b/packages/documentation/src/components/Accordion/accordion.scss @@ -7,6 +7,10 @@ * LICENSE file in the root directory of this source tree. */ +.Accordion > a { + display: flex; +} + .Accordion.Accordion__Last { border-block-end: solid 1px var(--theme-color-contrast-bdr); } From 79b01a784c4393a41ca05017323702057056fa65 Mon Sep 17 00:00:00 2001 From: Daniel Leroux Date: Mon, 16 Sep 2024 07:24:35 +0200 Subject: [PATCH 4/9] ci(strict-check): remove strict check --- .github/workflows/strict-check.yml | 115 ----------------------------- 1 file changed, 115 deletions(-) delete mode 100644 .github/workflows/strict-check.yml diff --git a/.github/workflows/strict-check.yml b/.github/workflows/strict-check.yml deleted file mode 100644 index f04f047bc5..0000000000 --- a/.github/workflows/strict-check.yml +++ /dev/null @@ -1,115 +0,0 @@ -name: Strict check - -on: - pull_request_target: - branches: - - '**' - -# Check is not necessary after strict is true IX-1332 -jobs: - strict_check: - permissions: - contents: read - pull-requests: write - strategy: - matrix: - branch: ['main', 'pr'] - name: 'Get strictNullChecks errors on ${{ matrix.branch }}' - runs-on: ubuntu-latest - steps: - - name: Checkout main - uses: actions/checkout@v4 - with: - ref: main - if: ${{ matrix.branch == 'main' }} - - - name: Checkout PR branch - uses: actions/checkout@v4 # v4.1.6 - with: - ref: ${{ github.event_name == 'pull_request_target' && format('refs/pull/{0}/merge', github.event.number) || '' }} - persist-credentials: false - if: ${{ matrix.branch == 'pr' }} - - - uses: ./.github/workflows/actions/turbo - - - name: ESLint check - run: | - ROOT=$(pwd) - cd ./packages/core - pnpm lint --format json -o $ROOT/eslint_${{ matrix.branch }}.json - cd $ROOT - - - name: Upload eslint_${{ matrix.branch }}.json - uses: actions/upload-artifact@v4 - with: - name: eslint_${{ matrix.branch }} - path: 'eslint_${{ matrix.branch }}.json' - - - name: TSC Check - run: | - ROOT=$(pwd) - npm install -g @aivenio/tsc-output-parser@2.1.1 - cd ./packages/core - npx tsc --strictNullChecks --strictPropertyInitialization --noEmit --pretty false | npx tsc-output-parser > $ROOT/strict_${{ matrix.branch }}.json - cd $ROOT - - - name: Upload strict_${{ matrix.branch }}.json - uses: actions/upload-artifact@v4 - with: - name: strict_${{ matrix.branch }} - path: 'strict_${{ matrix.branch }}.json' - - comment_on_pr: - permissions: - contents: read - pull-requests: write - needs: ['strict_check'] - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v4 - with: - ref: ${{ github.event_name == 'pull_request_target' && format('refs/pull/{0}/merge', github.event.number) || '' }} - persist-credentials: false - - - uses: ./.github/workflows/actions/turbo - - - name: Download strict error json for main branch - uses: actions/download-artifact@v4 - with: - name: strict_main - - - name: Download strict error json for pr branch - uses: actions/download-artifact@v4 - with: - name: strict_pr - - - name: Download eslint error json for main branch - uses: actions/download-artifact@v4 - with: - name: eslint_main - - - name: Download eslint error json for pr branch - uses: actions/download-artifact@v4 - with: - name: eslint_pr - - - name: Set comment body - id: report-body - run: pnpm ts-run scripts/strict-check.ts - - - name: Find Comment - uses: peter-evans/find-comment@v3 - id: find-comment - with: - issue-number: ${{ github.event.pull_request.number }} - comment-author: 'github-actions[bot]' - body-includes: '### Report of `strictNullChecks (strictPropertyInitialization)` check' - - - name: Create or update comment - uses: peter-evans/create-or-update-comment@v4 - with: - comment-id: ${{ steps.find-comment.outputs.comment-id }} - issue-number: ${{ github.event.pull_request.number }} - body: ${{ steps.report-body.outputs.body }} - edit-mode: replace From 94ffd4abe4ade3b6cd87a61bf37d609f487d2784 Mon Sep 17 00:00:00 2001 From: Daniel Leroux Date: Mon, 16 Sep 2024 11:01:52 +0200 Subject: [PATCH 5/9] docs(playground): fix react stackblitz env --- packages/documentation/src/utils/code-runtime/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/documentation/src/utils/code-runtime/index.ts b/packages/documentation/src/utils/code-runtime/index.ts index 10986495d4..f216db6371 100644 --- a/packages/documentation/src/utils/code-runtime/index.ts +++ b/packages/documentation/src/utils/code-runtime/index.ts @@ -41,7 +41,6 @@ export async function getReactRuntime(baseUrl: string) { 'tsconfig.json', 'package.json', 'index.html', - '.eslintrc.cjs', 'src/App.tsx', 'src/main.tsx', 'src/vite-env.d.ts', From 0b48e6b3f8ab8a1d419e8478d995b4c6e097a242 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 16 Sep 2024 11:53:24 +0200 Subject: [PATCH 6/9] Version Packages (#1410) Co-authored-by: github-actions[bot] --- .changeset/brown-forks-repeat.md | 5 ---- .changeset/curvy-sloths-prove.md | 5 ---- .changeset/fast-tips-jam.md | 5 ---- .changeset/fifty-gorillas-punch.md | 5 ---- .changeset/fuzzy-countries-jam.md | 5 ---- .changeset/giant-tigers-decide.md | 5 ---- .changeset/green-carrots-drum.md | 5 ---- .changeset/lemon-pants-act.md | 5 ---- .changeset/loud-moons-occur.md | 5 ---- .changeset/ninety-ligers-invite.md | 5 ---- .changeset/pink-ducks-thank.md | 5 ---- .changeset/silly-insects-decide.md | 5 ---- .changeset/spicy-ravens-care.md | 5 ---- .changeset/strong-impalas-flow.md | 5 ---- .changeset/thick-fireants-worry.md | 5 ---- .changeset/violet-ducks-refuse.md | 5 ---- .changeset/wicked-avocados-glow.md | 5 ---- .changeset/wicked-glasses-pump.md | 5 ---- packages/aggrid/CHANGELOG.md | 11 +++++++++ packages/aggrid/package.json | 4 ++-- packages/angular/CHANGELOG.md | 7 ++++++ packages/angular/package.json | 4 ++-- packages/core/CHANGELOG.md | 38 ++++++++++++++++++++++++++++++ packages/core/package.json | 2 +- packages/echarts/CHANGELOG.md | 6 +++++ packages/echarts/package.json | 2 +- packages/react/CHANGELOG.md | 7 ++++++ packages/react/package.json | 4 ++-- packages/vue/CHANGELOG.md | 7 ++++++ packages/vue/package.json | 4 ++-- pnpm-lock.yaml | 9 +++---- 31 files changed, 91 insertions(+), 104 deletions(-) delete mode 100644 .changeset/brown-forks-repeat.md delete mode 100644 .changeset/curvy-sloths-prove.md delete mode 100644 .changeset/fast-tips-jam.md delete mode 100644 .changeset/fifty-gorillas-punch.md delete mode 100644 .changeset/fuzzy-countries-jam.md delete mode 100644 .changeset/giant-tigers-decide.md delete mode 100644 .changeset/green-carrots-drum.md delete mode 100644 .changeset/lemon-pants-act.md delete mode 100644 .changeset/loud-moons-occur.md delete mode 100644 .changeset/ninety-ligers-invite.md delete mode 100644 .changeset/pink-ducks-thank.md delete mode 100644 .changeset/silly-insects-decide.md delete mode 100644 .changeset/spicy-ravens-care.md delete mode 100644 .changeset/strong-impalas-flow.md delete mode 100644 .changeset/thick-fireants-worry.md delete mode 100644 .changeset/violet-ducks-refuse.md delete mode 100644 .changeset/wicked-avocados-glow.md delete mode 100644 .changeset/wicked-glasses-pump.md diff --git a/.changeset/brown-forks-repeat.md b/.changeset/brown-forks-repeat.md deleted file mode 100644 index a76101e014..0000000000 --- a/.changeset/brown-forks-repeat.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': patch ---- - -fix(core/category-filter): does not clear category preview diff --git a/.changeset/curvy-sloths-prove.md b/.changeset/curvy-sloths-prove.md deleted file mode 100644 index b8c26ed426..0000000000 --- a/.changeset/curvy-sloths-prove.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix-aggrid': minor ---- - -feat(aggrid): update peerDependency to latest major version diff --git a/.changeset/fast-tips-jam.md b/.changeset/fast-tips-jam.md deleted file mode 100644 index 2a7d81952f..0000000000 --- a/.changeset/fast-tips-jam.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': patch ---- - -fix(core/tooltip): cutoff near viewport edges diff --git a/.changeset/fifty-gorillas-punch.md b/.changeset/fifty-gorillas-punch.md deleted file mode 100644 index 44fd6159a4..0000000000 --- a/.changeset/fifty-gorillas-punch.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': patch ---- - -fix(core/dropdown): spacing and color diff --git a/.changeset/fuzzy-countries-jam.md b/.changeset/fuzzy-countries-jam.md deleted file mode 100644 index ba631ec0d7..0000000000 --- a/.changeset/fuzzy-countries-jam.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@siemens/ix": patch ---- - -fix(core/select): set value before triggering event diff --git a/.changeset/giant-tigers-decide.md b/.changeset/giant-tigers-decide.md deleted file mode 100644 index 029c119d4b..0000000000 --- a/.changeset/giant-tigers-decide.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': minor ---- - -feat(core/push-card): add alternative card types diff --git a/.changeset/green-carrots-drum.md b/.changeset/green-carrots-drum.md deleted file mode 100644 index a95f3c68db..0000000000 --- a/.changeset/green-carrots-drum.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': patch ---- - -fix(core/tooltip): styles bleeding in diff --git a/.changeset/lemon-pants-act.md b/.changeset/lemon-pants-act.md deleted file mode 100644 index afc24a616b..0000000000 --- a/.changeset/lemon-pants-act.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@siemens/ix": patch ---- - -fix(core/tree): handle text overflow gracefully diff --git a/.changeset/loud-moons-occur.md b/.changeset/loud-moons-occur.md deleted file mode 100644 index d547ea6fc0..0000000000 --- a/.changeset/loud-moons-occur.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@siemens/ix": patch ---- - -fix(core/card-list): card-list show all not getting truncated diff --git a/.changeset/ninety-ligers-invite.md b/.changeset/ninety-ligers-invite.md deleted file mode 100644 index 829a9b8278..0000000000 --- a/.changeset/ninety-ligers-invite.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': patch ---- - -fix(core/tooltip): cancel tooltip positioning when reference is not visible diff --git a/.changeset/pink-ducks-thank.md b/.changeset/pink-ducks-thank.md deleted file mode 100644 index 26386f3114..0000000000 --- a/.changeset/pink-ducks-thank.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix-echarts': minor ---- - -feat(echarts): add utility function to access color variables diff --git a/.changeset/silly-insects-decide.md b/.changeset/silly-insects-decide.md deleted file mode 100644 index a6c37c718e..0000000000 --- a/.changeset/silly-insects-decide.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@siemens/ix": patch ---- - -fix(core): export TypedEvent diff --git a/.changeset/spicy-ravens-care.md b/.changeset/spicy-ravens-care.md deleted file mode 100644 index f377f150e0..0000000000 --- a/.changeset/spicy-ravens-care.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@siemens/ix": patch ---- - -fix(core/tree): prevent hyperlist from disposing dropdowns linked to tree items diff --git a/.changeset/strong-impalas-flow.md b/.changeset/strong-impalas-flow.md deleted file mode 100644 index 63d96ba25c..0000000000 --- a/.changeset/strong-impalas-flow.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': patch ---- - -fix(core/menu-item): occasionally empty tooltips in menu-item diff --git a/.changeset/thick-fireants-worry.md b/.changeset/thick-fireants-worry.md deleted file mode 100644 index 5734a8c9c2..0000000000 --- a/.changeset/thick-fireants-worry.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': minor ---- - -feat(core): add css safe areas diff --git a/.changeset/violet-ducks-refuse.md b/.changeset/violet-ducks-refuse.md deleted file mode 100644 index 154e9f1750..0000000000 --- a/.changeset/violet-ducks-refuse.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': patch ---- - -fix(core/group): remove max-width restriction diff --git a/.changeset/wicked-avocados-glow.md b/.changeset/wicked-avocados-glow.md deleted file mode 100644 index 75b3e8856c..0000000000 --- a/.changeset/wicked-avocados-glow.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': minor ---- - -feat(core/group): handle preventDefault for events diff --git a/.changeset/wicked-glasses-pump.md b/.changeset/wicked-glasses-pump.md deleted file mode 100644 index 1be9415fff..0000000000 --- a/.changeset/wicked-glasses-pump.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@siemens/ix': minor ---- - -feat(core/application-header): hide toggle menu if header used outside of application frame diff --git a/packages/aggrid/CHANGELOG.md b/packages/aggrid/CHANGELOG.md index c10c17b371..fade47724c 100644 --- a/packages/aggrid/CHANGELOG.md +++ b/packages/aggrid/CHANGELOG.md @@ -1,5 +1,16 @@ # @siemens/ix-aggrid +## 2.2.0 + +### Minor Changes + +- [#1450](https://github.com/siemens/ix/pull/1450) [`7181098e9a`](https://github.com/siemens/ix/commit/7181098e9a044a29edf6507377e24a7c82fe7591) Thanks [@danielleroux](https://github.com/danielleroux)! - feat(aggrid): update peerDependency to latest major version + +### Patch Changes + +- Updated dependencies [[`a69f108ba8`](https://github.com/siemens/ix/commit/a69f108ba8676b5f4c6f0d3dc4cfa9d483c89f53), [`501cce588b`](https://github.com/siemens/ix/commit/501cce588b44881c934c45cdfa5795ebafcbb644), [`b4a306ef90`](https://github.com/siemens/ix/commit/b4a306ef909704cb3f0a5826b34aa52f0cbcb276), [`1b4da95e21`](https://github.com/siemens/ix/commit/1b4da95e21aea5a28ede042289e38dd88c79512f), [`c8b2d3caf2`](https://github.com/siemens/ix/commit/c8b2d3caf263982133af881e72bafca7cdb7dc38), [`5acd52a874`](https://github.com/siemens/ix/commit/5acd52a8741889af40ebde253ee35c6b5c8a1be6), [`c19a537552`](https://github.com/siemens/ix/commit/c19a5375524a9c29bc4380119f40d3d829c104ce), [`938ca56ca5`](https://github.com/siemens/ix/commit/938ca56ca58def8c96267db8044d2f44110cbf69), [`00c68b5af2`](https://github.com/siemens/ix/commit/00c68b5af2dfb7c9baa99bc1645124c30e9788e2), [`5343eed4ea`](https://github.com/siemens/ix/commit/5343eed4eab708148139036aab3f3b0e5699df39), [`2401b2ee27`](https://github.com/siemens/ix/commit/2401b2ee27d4975cbe77bab2c6300abc791f4310), [`69658147c8`](https://github.com/siemens/ix/commit/69658147c8e462504e6ec30790d44f60dfec97e1), [`34ddfd0410`](https://github.com/siemens/ix/commit/34ddfd041025b251451d46668bc733d84b176c14), [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c), [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c), [`f91b0a5bed`](https://github.com/siemens/ix/commit/f91b0a5bed9c41aa8a94c4142cc381592fa3b7ed)]: + - @siemens/ix@2.5.0 + ## 2.1.6 ### Patch Changes diff --git a/packages/aggrid/package.json b/packages/aggrid/package.json index ae250e4eba..17e70f7842 100644 --- a/packages/aggrid/package.json +++ b/packages/aggrid/package.json @@ -8,7 +8,7 @@ "directory": "packages/aggrid" }, "description": "AG Grid theme based on ix theme variables", - "version": "2.1.6", + "version": "2.2.0", "files": [ "LICENSE", "README.md", @@ -38,7 +38,7 @@ "ts-node": "^10.9.1" }, "dependencies": { - "@siemens/ix": "~2.4.1" + "@siemens/ix": "~2.5.0" }, "peerDependencies": { "ag-grid-community": ">=28" diff --git a/packages/angular/CHANGELOG.md b/packages/angular/CHANGELOG.md index 0e6d2f117e..3ceed7abbc 100644 --- a/packages/angular/CHANGELOG.md +++ b/packages/angular/CHANGELOG.md @@ -1,5 +1,12 @@ # @siemens/ix-angular +## 2.5.0 + +### Patch Changes + +- Updated dependencies [[`a69f108ba8`](https://github.com/siemens/ix/commit/a69f108ba8676b5f4c6f0d3dc4cfa9d483c89f53), [`501cce588b`](https://github.com/siemens/ix/commit/501cce588b44881c934c45cdfa5795ebafcbb644), [`b4a306ef90`](https://github.com/siemens/ix/commit/b4a306ef909704cb3f0a5826b34aa52f0cbcb276), [`1b4da95e21`](https://github.com/siemens/ix/commit/1b4da95e21aea5a28ede042289e38dd88c79512f), [`c8b2d3caf2`](https://github.com/siemens/ix/commit/c8b2d3caf263982133af881e72bafca7cdb7dc38), [`5acd52a874`](https://github.com/siemens/ix/commit/5acd52a8741889af40ebde253ee35c6b5c8a1be6), [`c19a537552`](https://github.com/siemens/ix/commit/c19a5375524a9c29bc4380119f40d3d829c104ce), [`938ca56ca5`](https://github.com/siemens/ix/commit/938ca56ca58def8c96267db8044d2f44110cbf69), [`00c68b5af2`](https://github.com/siemens/ix/commit/00c68b5af2dfb7c9baa99bc1645124c30e9788e2), [`5343eed4ea`](https://github.com/siemens/ix/commit/5343eed4eab708148139036aab3f3b0e5699df39), [`2401b2ee27`](https://github.com/siemens/ix/commit/2401b2ee27d4975cbe77bab2c6300abc791f4310), [`69658147c8`](https://github.com/siemens/ix/commit/69658147c8e462504e6ec30790d44f60dfec97e1), [`34ddfd0410`](https://github.com/siemens/ix/commit/34ddfd041025b251451d46668bc733d84b176c14), [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c), [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c), [`f91b0a5bed`](https://github.com/siemens/ix/commit/f91b0a5bed9c41aa8a94c4142cc381592fa3b7ed)]: + - @siemens/ix@2.5.0 + ## 2.4.1 ### Patch Changes diff --git a/packages/angular/package.json b/packages/angular/package.json index dd1e5e8327..36e0a138d9 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -7,7 +7,7 @@ "url": "https://github.com/siemens/ix", "directory": "packages/angular" }, - "version": "2.4.1", + "version": "2.5.0", "description": "Siemens iX for Angular", "scripts": { "build": "ng-packagr -c tsconfig.json", @@ -16,7 +16,7 @@ }, "license": "MIT", "dependencies": { - "@siemens/ix": "~2.4.1" + "@siemens/ix": "~2.5.0" }, "peerDependencies": { "@angular/core": ">=13.4.0", diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md index 3fbe0a495f..0f6ad9a2e0 100644 --- a/packages/core/CHANGELOG.md +++ b/packages/core/CHANGELOG.md @@ -1,5 +1,43 @@ # @siemens/ix +## 2.5.0 + +### Minor Changes + +- [#1317](https://github.com/siemens/ix/pull/1317) [`c8b2d3caf2`](https://github.com/siemens/ix/commit/c8b2d3caf263982133af881e72bafca7cdb7dc38) Thanks [@matthiashader](https://github.com/matthiashader)! - feat(core/push-card): add alternative card types + +- [#1422](https://github.com/siemens/ix/pull/1422) [`34ddfd0410`](https://github.com/siemens/ix/commit/34ddfd041025b251451d46668bc733d84b176c14) Thanks [@danielleroux](https://github.com/danielleroux)! - feat(core): add css safe areas + +- [#1454](https://github.com/siemens/ix/pull/1454) [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c) Thanks [@danielleroux](https://github.com/danielleroux)! - feat(core/group): handle preventDefault for events + +- [#1449](https://github.com/siemens/ix/pull/1449) [`f91b0a5bed`](https://github.com/siemens/ix/commit/f91b0a5bed9c41aa8a94c4142cc381592fa3b7ed) Thanks [@danielleroux](https://github.com/danielleroux)! - feat(core/application-header): hide toggle menu if header used outside of application frame + +### Patch Changes + +- [#1441](https://github.com/siemens/ix/pull/1441) [`a69f108ba8`](https://github.com/siemens/ix/commit/a69f108ba8676b5f4c6f0d3dc4cfa9d483c89f53) Thanks [@matthiashader](https://github.com/matthiashader)! - fix(core/category-filter): does not clear category preview + +- [#1462](https://github.com/siemens/ix/pull/1462) [`501cce588b`](https://github.com/siemens/ix/commit/501cce588b44881c934c45cdfa5795ebafcbb644) Thanks [@matthiashader](https://github.com/matthiashader)! - fix(core/tooltip): cutoff near viewport edges + +- [#1343](https://github.com/siemens/ix/pull/1343) [`b4a306ef90`](https://github.com/siemens/ix/commit/b4a306ef909704cb3f0a5826b34aa52f0cbcb276) Thanks [@matthiashader](https://github.com/matthiashader)! - fix(core/dropdown): spacing and color + +- [#1401](https://github.com/siemens/ix/pull/1401) [`1b4da95e21`](https://github.com/siemens/ix/commit/1b4da95e21aea5a28ede042289e38dd88c79512f) Thanks [@nuke-ellington](https://github.com/nuke-ellington)! - fix(core/select): set value before triggering event + +- [#1444](https://github.com/siemens/ix/pull/1444) [`5acd52a874`](https://github.com/siemens/ix/commit/5acd52a8741889af40ebde253ee35c6b5c8a1be6) Thanks [@matthiashader](https://github.com/matthiashader)! - fix(core/tooltip): styles bleeding in + +- [#1428](https://github.com/siemens/ix/pull/1428) [`c19a537552`](https://github.com/siemens/ix/commit/c19a5375524a9c29bc4380119f40d3d829c104ce) Thanks [@nuke-ellington](https://github.com/nuke-ellington)! - fix(core/tree): handle text overflow gracefully + +- [#1354](https://github.com/siemens/ix/pull/1354) [`938ca56ca5`](https://github.com/siemens/ix/commit/938ca56ca58def8c96267db8044d2f44110cbf69) Thanks [@ridvandmrc](https://github.com/ridvandmrc)! - fix(core/card-list): card-list show all not getting truncated + +- [#1438](https://github.com/siemens/ix/pull/1438) [`00c68b5af2`](https://github.com/siemens/ix/commit/00c68b5af2dfb7c9baa99bc1645124c30e9788e2) Thanks [@matthiashader](https://github.com/matthiashader)! - fix(core/tooltip): cancel tooltip positioning when reference is not visible + +- [#1409](https://github.com/siemens/ix/pull/1409) [`5343eed4ea`](https://github.com/siemens/ix/commit/5343eed4eab708148139036aab3f3b0e5699df39) Thanks [@danielleroux](https://github.com/danielleroux)! - fix(core): export TypedEvent + +- [#1460](https://github.com/siemens/ix/pull/1460) [`2401b2ee27`](https://github.com/siemens/ix/commit/2401b2ee27d4975cbe77bab2c6300abc791f4310) Thanks [@nuke-ellington](https://github.com/nuke-ellington)! - fix(core/tree): prevent hyperlist from disposing dropdowns linked to tree items + +- [#1370](https://github.com/siemens/ix/pull/1370) [`69658147c8`](https://github.com/siemens/ix/commit/69658147c8e462504e6ec30790d44f60dfec97e1) Thanks [@matthiashader](https://github.com/matthiashader)! - fix(core/menu-item): occasionally empty tooltips in menu-item + +- [#1454](https://github.com/siemens/ix/pull/1454) [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c) Thanks [@danielleroux](https://github.com/danielleroux)! - fix(core/group): remove max-width restriction + ## 2.4.1 ### Patch Changes diff --git a/packages/core/package.json b/packages/core/package.json index 9009f93462..343d7c49a1 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -7,7 +7,7 @@ "url": "https://github.com/siemens/ix", "directory": "packages/core" }, - "version": "2.4.1", + "version": "2.5.0", "license": "MIT", "description": "Siemens iX Web Components", "main": "dist/index.cjs.js", diff --git a/packages/echarts/CHANGELOG.md b/packages/echarts/CHANGELOG.md index 3ffadb8771..c82e7bef37 100644 --- a/packages/echarts/CHANGELOG.md +++ b/packages/echarts/CHANGELOG.md @@ -1,5 +1,11 @@ # @siemens/ix-echarts +## 2.3.0 + +### Minor Changes + +- [#1421](https://github.com/siemens/ix/pull/1421) [`4804d54c4b`](https://github.com/siemens/ix/commit/4804d54c4b7cc70a8c155397d0c4ef9eefa13ec4) Thanks [@matthiashader](https://github.com/matthiashader)! - feat(echarts): add utility function to access color variables + ## 2.2.0 ### Minor Changes diff --git a/packages/echarts/package.json b/packages/echarts/package.json index 66dea1f64a..0c08d52f57 100644 --- a/packages/echarts/package.json +++ b/packages/echarts/package.json @@ -7,7 +7,7 @@ "url": "https://github.com/siemens/ix", "directory": "packages/echarts" }, - "version": "2.2.0", + "version": "2.3.0", "description": "Siemens iX theme for echarts", "main": "dist/index.js", "module": "dist/index.esm.js", diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index fa4a00b0fb..08699ded3c 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -1,5 +1,12 @@ # @siemens/ix-react +## 2.5.0 + +### Patch Changes + +- Updated dependencies [[`a69f108ba8`](https://github.com/siemens/ix/commit/a69f108ba8676b5f4c6f0d3dc4cfa9d483c89f53), [`501cce588b`](https://github.com/siemens/ix/commit/501cce588b44881c934c45cdfa5795ebafcbb644), [`b4a306ef90`](https://github.com/siemens/ix/commit/b4a306ef909704cb3f0a5826b34aa52f0cbcb276), [`1b4da95e21`](https://github.com/siemens/ix/commit/1b4da95e21aea5a28ede042289e38dd88c79512f), [`c8b2d3caf2`](https://github.com/siemens/ix/commit/c8b2d3caf263982133af881e72bafca7cdb7dc38), [`5acd52a874`](https://github.com/siemens/ix/commit/5acd52a8741889af40ebde253ee35c6b5c8a1be6), [`c19a537552`](https://github.com/siemens/ix/commit/c19a5375524a9c29bc4380119f40d3d829c104ce), [`938ca56ca5`](https://github.com/siemens/ix/commit/938ca56ca58def8c96267db8044d2f44110cbf69), [`00c68b5af2`](https://github.com/siemens/ix/commit/00c68b5af2dfb7c9baa99bc1645124c30e9788e2), [`5343eed4ea`](https://github.com/siemens/ix/commit/5343eed4eab708148139036aab3f3b0e5699df39), [`2401b2ee27`](https://github.com/siemens/ix/commit/2401b2ee27d4975cbe77bab2c6300abc791f4310), [`69658147c8`](https://github.com/siemens/ix/commit/69658147c8e462504e6ec30790d44f60dfec97e1), [`34ddfd0410`](https://github.com/siemens/ix/commit/34ddfd041025b251451d46668bc733d84b176c14), [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c), [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c), [`f91b0a5bed`](https://github.com/siemens/ix/commit/f91b0a5bed9c41aa8a94c4142cc381592fa3b7ed)]: + - @siemens/ix@2.5.0 + ## 2.4.1 ### Patch Changes diff --git a/packages/react/package.json b/packages/react/package.json index 22ff3577f2..a53a87e324 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -7,7 +7,7 @@ "url": "https://github.com/siemens/ix", "directory": "packages/react" }, - "version": "2.4.1", + "version": "2.5.0", "description": "Siemens iX for React", "main": "dist/index.js", "module": "dist/index.esm.js", @@ -63,6 +63,6 @@ "react-dom": ">=17.0.2" }, "dependencies": { - "@siemens/ix": "~2.4.1" + "@siemens/ix": "~2.5.0" } } diff --git a/packages/vue/CHANGELOG.md b/packages/vue/CHANGELOG.md index 46f8e6bb57..74df5ca4be 100644 --- a/packages/vue/CHANGELOG.md +++ b/packages/vue/CHANGELOG.md @@ -1,5 +1,12 @@ # @siemens/ix-vue +## 2.5.0 + +### Patch Changes + +- Updated dependencies [[`a69f108ba8`](https://github.com/siemens/ix/commit/a69f108ba8676b5f4c6f0d3dc4cfa9d483c89f53), [`501cce588b`](https://github.com/siemens/ix/commit/501cce588b44881c934c45cdfa5795ebafcbb644), [`b4a306ef90`](https://github.com/siemens/ix/commit/b4a306ef909704cb3f0a5826b34aa52f0cbcb276), [`1b4da95e21`](https://github.com/siemens/ix/commit/1b4da95e21aea5a28ede042289e38dd88c79512f), [`c8b2d3caf2`](https://github.com/siemens/ix/commit/c8b2d3caf263982133af881e72bafca7cdb7dc38), [`5acd52a874`](https://github.com/siemens/ix/commit/5acd52a8741889af40ebde253ee35c6b5c8a1be6), [`c19a537552`](https://github.com/siemens/ix/commit/c19a5375524a9c29bc4380119f40d3d829c104ce), [`938ca56ca5`](https://github.com/siemens/ix/commit/938ca56ca58def8c96267db8044d2f44110cbf69), [`00c68b5af2`](https://github.com/siemens/ix/commit/00c68b5af2dfb7c9baa99bc1645124c30e9788e2), [`5343eed4ea`](https://github.com/siemens/ix/commit/5343eed4eab708148139036aab3f3b0e5699df39), [`2401b2ee27`](https://github.com/siemens/ix/commit/2401b2ee27d4975cbe77bab2c6300abc791f4310), [`69658147c8`](https://github.com/siemens/ix/commit/69658147c8e462504e6ec30790d44f60dfec97e1), [`34ddfd0410`](https://github.com/siemens/ix/commit/34ddfd041025b251451d46668bc733d84b176c14), [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c), [`da1f10e8ca`](https://github.com/siemens/ix/commit/da1f10e8ca6c639ff7e549454f5de4a76505204c), [`f91b0a5bed`](https://github.com/siemens/ix/commit/f91b0a5bed9c41aa8a94c4142cc381592fa3b7ed)]: + - @siemens/ix@2.5.0 + ## 2.4.1 ### Patch Changes diff --git a/packages/vue/package.json b/packages/vue/package.json index d81c4560f0..c33e62f490 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -3,7 +3,7 @@ "homepage": "https://ix.siemens.io", "author": "Siemens AG", "license": "MIT", - "version": "2.4.1", + "version": "2.5.0", "description": "Siemens iX for Vue", "bugs": "https://github.com/siemens/ix/issues", "repository": { @@ -31,7 +31,7 @@ "lint": "eslint src" }, "dependencies": { - "@siemens/ix": "~2.4.1" + "@siemens/ix": "~2.5.0" }, "devDependencies": { "rimraf": "^3.0.2", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 81623025f7..7f72525bf8 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -64,7 +64,7 @@ importers: packages/aggrid: dependencies: '@siemens/ix': - specifier: ~2.4.1 + specifier: ~2.5.0 version: link:../core devDependencies: '@playwright/test': @@ -116,7 +116,7 @@ importers: packages/angular: dependencies: '@siemens/ix': - specifier: ~2.4.1 + specifier: ~2.5.0 version: link:../core '@siemens/ix-icons': specifier: ^2.0.0 @@ -762,7 +762,7 @@ importers: packages/react: dependencies: '@siemens/ix': - specifier: ~2.4.1 + specifier: ~2.5.0 version: link:../core '@siemens/ix-icons': specifier: ^2.0.0 @@ -914,7 +914,7 @@ importers: packages/vue: dependencies: '@siemens/ix': - specifier: ~2.4.1 + specifier: ~2.5.0 version: link:../core '@siemens/ix-icons': specifier: ^2.0.0 @@ -4039,6 +4039,7 @@ packages: '@playwright/test@1.39.0': resolution: {integrity: sha512-3u1iFqgzl7zr004bGPYiN/5EZpRUSFddQBra8Rqll5N0/vfpqlP9I9EXqAoGacuAbX6c9Ulg/Cjqglp5VkK6UQ==} engines: {node: '>=16'} + deprecated: Please update to the latest version of Playwright to test up-to-date browsers. hasBin: true '@pnpm/config.env-replace@1.1.0': From d5affb02b371e3541c546e272e2389b678630dd4 Mon Sep 17 00:00:00 2001 From: matthiashader <144090716+matthiashader@users.noreply.github.com> Date: Mon, 16 Sep 2024 15:50:29 +0200 Subject: [PATCH 7/9] fix(core/slider): show tooltip also for float numbers (#1468) --- .changeset/many-pumpkins-knock.md | 5 +++++ .../core/src/components/slider/slider.tsx | 2 +- packages/core/src/tests/slider/slider.e2e.ts | 21 ++++++++++++++++++ ...-1-chromium---theme-classic-dark-linux.png | Bin 0 -> 8851 bytes ...1-chromium---theme-classic-light-linux.png | Bin 0 -> 8019 bytes 5 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 .changeset/many-pumpkins-knock.md create mode 100644 packages/core/src/tests/slider/slider.e2e.ts-snapshots/should-show-float-steps-1-chromium---theme-classic-dark-linux.png create mode 100644 packages/core/src/tests/slider/slider.e2e.ts-snapshots/should-show-float-steps-1-chromium---theme-classic-light-linux.png diff --git a/.changeset/many-pumpkins-knock.md b/.changeset/many-pumpkins-knock.md new file mode 100644 index 0000000000..b5ff158eac --- /dev/null +++ b/.changeset/many-pumpkins-knock.md @@ -0,0 +1,5 @@ +--- +'@siemens/ix': patch +--- + +fix(core/slider): update tooltip on steps below 1 diff --git a/packages/core/src/components/slider/slider.tsx b/packages/core/src/components/slider/slider.tsx index 881f510955..f3106fab6b 100644 --- a/packages/core/src/components/slider/slider.tsx +++ b/packages/core/src/components/slider/slider.tsx @@ -154,7 +154,7 @@ export class Slider { private onInput(event: InputEvent) { event.stopPropagation(); - const value = parseInt(this.slider.value); + const value = parseFloat(this.slider.value); if (!isNaN(value)) { this.rangeInput = value; diff --git a/packages/core/src/tests/slider/slider.e2e.ts b/packages/core/src/tests/slider/slider.e2e.ts index 8d7693e42e..26576cead5 100644 --- a/packages/core/src/tests/slider/slider.e2e.ts +++ b/packages/core/src/tests/slider/slider.e2e.ts @@ -85,6 +85,27 @@ test('should render marker', async ({ page, mount }) => { expect(await page.locator('ix-slider').screenshot()).toMatchSnapshot(); }); +test('should show float steps', async ({ page, mount }) => { + await mount(` + + `); + + const slider = page.locator('ix-slider'); + await expect(slider).toHaveClass(/hydrated/); + + await slider.hover(); + await page.mouse.move(100, 0); + await page.mouse.down(); + + expect(await page.screenshot({ fullPage: true })).toMatchSnapshot(); +}); + test('should render with min-max changes', async ({ page, mount }) => { await mount(`
diff --git a/packages/core/src/tests/slider/slider.e2e.ts-snapshots/should-show-float-steps-1-chromium---theme-classic-dark-linux.png b/packages/core/src/tests/slider/slider.e2e.ts-snapshots/should-show-float-steps-1-chromium---theme-classic-dark-linux.png new file mode 100644 index 0000000000000000000000000000000000000000..c900255e06e94d25903a22f546679ba85a7fa31d GIT binary patch literal 8851 zcmeHNSzJ?Bw?7aD6=e9ZVhoeEinj=8F$S5nAoWwhRsl6kiV`6}7=$1J610|56l|#= zAflfN5(oh?gh5CI1X~OdH3MNt01+W1fDnQtB=?-$-sk&rA9+aj*=yQs@3r>Y|9yTZ z=Y*f{#tmCH006M@$PeB>0e~*}sQqT09@wxmh6BMyE9ocSLqKhx#S{S807twJo=Uwt zGmO4L!G!e8t6iN4v)wkOg~M<4Onr7uoG@7ooaitx`gY5cJC~S=d-M!+BW|R&yt!o9 zZ*taXM5J|UPk&e94)fp4qeXg0z0kW7O}-tr|FiMUMgl%E)RB9IRZ>ig96>fL;XKMO z%qFJ^@$Og$#+7^WsJ_so5H#oy;Pr?$ZUsF6b#B@=P^)7GXn~ClzdOM={Hqub^>rD) zm)PEz`3X*2eTF#|z!8{Bt7L3qtzX86+34|;@l(JiKs?(Uu(LsI_g;_(2i{_+$Sn>@v#N;175R^2xWskX8OJ(99%-1#T# zw0?hXhQ6D;#G3Hq@TO%{mN!u)#aqcuKv5CD>=m3OeEyjXD_4ljj4~Y{0~RzhIKV@p z@(G&h#D4>N@_Yp$x9)9**zxa68hF7xE4fXc054oZC(q017N3TkW{LQa`99C-RBuSC z&cZfPPgF%*KEZi>G`Bo;wBJQ0Cl0QXAZGXx&}6V$=*TUWEC1@43`tP9Mz7k1o$dHl z!#)7AYsfAO=Cc%9tB1RM9*ZYd_^DZnBIoUpz^9R%jU?7mio4XDSkd=fJsf~Ww^}#R z0xH!?cUe=|@>FyqJwJ{F$-c=lYhM5A8EcYJXQe0(;&IH+9X1ga( z=Na?5D?P5f{#plAAYC*4Crxrfv<)E>wlBbh5joQ&=L@V$E6%+A0V0MUa1aAcmzbqJ z-Q8(m_~N8PTRzkYZEc{0iGS}<3N+o|qhcc>+G<_okI3Y-Iq@XsFthWH4B>qcGEf-x zcvg$wD47#J-8d%fuDU63ru7p>$~QJ0^ZkN=a=`gYpaWp#Yl6rpcFObiXdC^S1u0&R zeXK1?_?aq`mCfVAO|*EtdLrEdSJv{d2CtRR!4$WbNHTrN3^n`TOd zXSSG_LMck}L1L)Q($m}`tKC4}m~e?3Smu$`Vnv(?NM2biJ}bP_aM7q;et%o+iv{|A zl=$uAT-hs>bGP;#LB+A9z$N6b4Zq53^Ms7#?QFN z^9sA;rD|u2u4cVLeYXO}jf?nA>R%iMja;59pK;;dI{uH!>S>8buw+jE=5|q5pm#0_ zvOR;N6#>Ry2f3yX1P;b31$NpgThxb(Vib&X%Y9OzF(i}ytV1h4eQH+3Sn_I^SVG!q zJ8VoPu>HaPpVtjfN-3JWS@9hpBz@c)9)RxcWG%*ENJ2{*h z5%PTT^s0iWB(%vhW~*5&N^uWkPS-OSm%1tz>$j_`WOHBVzxT{od?*XDR*JG13{(%b ztVGOP3@z1!*eg3QUN78rVd{fvb}xyc7{pN}jnjqn=d{d8Jdt`&K7KX$w_pVdy_)ze$sA(u%o*FOM0Cyo{p{83T< z`Oh@f!o4v1a0($qHbUjPmoq9=(=h8NMQw{0o$`rqX*{kcaVA2RWvogr^CS{8lxF2m zhzh#;2{^~`2i^S~z4jDsP3Rq~={l*?_fpN|YQ)gKSre8R&I=2Zd&U#pms$GRv%|81 zR`JY0L-H_alqYS)jV-&*K5vjdU+Bw`-%FL|$fo>>AH!i=hG2D3)q=?7K-}!_s+F)_ z5>z`ry?ToQ9QJ=7`=w!^&qGBJqlGKnE<(QBTSCUt%(&cL4bC*dT~_5!Au3;49)$~E zDTxLRn##v#O|yWS{tJxyDk2izyOvc58E zFl~>^zz*YuU;4V=1)^CsA29GekO9ln4?;+jx#`(Av+zV|QnIWW{BeSeg#>9s`AOr< z1w^t+x$4CJGJ$G;aBsB+G0nm?(+ZYRYFynjbI<^(^UMRlIW7ivD~E1O*ZLuV(T z%bLf2bHPi4%UtobwdozV^{u(;TE1~Db+Hi-c$L|vlflZ zINCP3G&ntmZ%3;?Q`KjQ3lEHqJ=Il3?T@4_irN;1l+E>5^7DDcPC@Sp!qs~@*z~ER zVPsz0{LSpGzJp6R&!)k|f5Pbe=;I8MXP^A{z>w?vrF?`+xWtYfj0S5Mp_LqqB@kL0 z>HEb|>@?}qU!I=|YZ5!r8ry%wVzB|oPqGAOXRS!bPab#TYh9SBC9%?V>xvhgp+)v9 z{3=A-?QvP^ui-BpA%gF@>oAek#hJvsNJ8FfqUsz(toaYekYw9@t?Yx)2<&=I208&y zO$5qL{|+<>pV2==CD?wU!$3-1jNQL9xkI|xbWA(EVSIwi{WxzpVFDf&c;%mP9Hi!j zaVP+sDOF%?2GPT2E}}uC50aVvXFzlQo3LqWWB_O1aU}M*`yvzOyQek|YB@E?HsOhY z0G5UO2~A}Zi2}a?`kp2Y;E<~^+z8+@LF?HDx<(`Y1i*D+md!DRkTyBQ%{t|n*T$XvzDf0j{?x**E z>oP+dOV7fFo;_rziAmYMi&sUvaeK-@N_uMGT`}#53F=61^Yo zja>N_(teY}Sx+i3TUv6y^z90*fLdKr55MZlo}CUQnbqUc(^<=yRX7RRY?xZ3l*o5L zD)GCj&45ZULi;)UB$wdv@A7;Yk&~|(jVnFJ3L6>^>mwI#cOTG0r3qfA_UDqu55}9Q z4>zcH7O7L}9pI3Kos<*6klkxpp%yCkWUSMjFTA|%;hs{N)nOid_YSMtr?EY?sC_uY zyR^}s54ru(BlRI9f`9i|m{Yx5>g;soIt{dPw%Y_?w@mGvg*h+r4I5`;R}eox>#WgV0?>9E8(>|<78-uZV&F0llrsmi8$gr1Q#J`^esfKePxTlDOpNsL}8@kXJx zyii{*#O)jxE^;l#<*TKtn%up9yAN0mEl{Il3T{Q7FP>eVXI+MAprMhyI~cT+v8}JZ z8$8ovB-M3p-;`P>qRaV9co=-xAbw`X$9Ba&ItC?*T#@m=6R8{r>JPqhFb@%lIp0I0 zN21%{q<6g}+rm{pALi&H^T(vpd#29(olT`}M2s zUfwrgF*k_s89;j2)zN3@)>;ab4BL~U6}7_d!K)~O$|?z}u{n~DEEr9QToy9~3C-8c zJsUJNncoZ6bBj_L>KO5)|1YL>(awmv=x=qFJQ4ZW&RwU?{689|M~ov3lk(YV#;z#k zojdTRg>%tK5dH$3?|x-S3K(xtMcV6H`7l-D3gV3SItvTe=cjO?;g#YTjK5<{WKdfO z7^dWwWoSct;RE*p+^)Zc&D%w%hp^o#K$QHq%-q_4k33{ahSsNkei=OPuYk(N{fKG= zfRV0qv((a;D-q~_1tag8@(C@30Bq^Y4Wh;1Hp|Yk`SZTZ2#>O4dtD76jHAQ@HCs!^ zP{$$)oV0w)ZyXXW_ajYV_~6XwoH;A~J}3TPL9Hy8yUjEBF(_)lr`NyhGGVhiZkx5L zD+*yjlC9d+kzLFX#=`<_XU<&Yb;d|R?O3^`=HTSBquGE3-(EWq6w|MiAls;A34NKJ z{PA}gBXN<|JI0{xTjyQm3)D`}!Y2eo7#H|T6aTt+r(TK2ESG-K+@&s0 z{{RzZ6=~(y)$d0y)At?-c|(-yNB9~SwCl_uwN~+rP&{Nl)PmXqyi!v2;F9G7UkLH zx!(w(i+3=Rj3T;orR^Ovo{+%icsLsvI_|U(#r}OrM-$h;?s{FO6rYwhxQt17YPKeM=#8wG~N4wV^*YV%;d$RSA$CDG`0JjrNWSzaFzEf z1DXa9aykc28t?Ap9Vs>4wF0^PhIZS4H12oEaFfQ>(-pUkNaK;$pZ3~s_$>ocv7q(t z1o{&B_Zu&HZJL89O+&$4t+_fKcc}B0^4@_7J$TV|yr6d7P5^SoYmb&@9#_|sAgakR zK(j-`wQZp8|6cX)XrLkRVoh~znf`hEvz8KTJ7=v*tX0IdgJbQGT*DG;xXES>5Uc@$ zH9)Wi2-X0>|1ThrNBOvbUkMz9z6AiUVE^?pP@nk literal 0 HcmV?d00001 diff --git a/packages/core/src/tests/slider/slider.e2e.ts-snapshots/should-show-float-steps-1-chromium---theme-classic-light-linux.png b/packages/core/src/tests/slider/slider.e2e.ts-snapshots/should-show-float-steps-1-chromium---theme-classic-light-linux.png new file mode 100644 index 0000000000000000000000000000000000000000..8e25c2881e8ce10816965a9468763deaaef4d4ba GIT binary patch literal 8019 zcmeHL>tB;c7Jefrh#*>5EqByaY*j=k_p7ZGSpNR%#XaSxbtb zpmi-Y5W>|cw}fJi3J3}bLI?ptD7gY52?Rnmlilub|AhU(r+H`2InOyWbIvm}@3k+2 z{EQ4t4Il_I@;`m*ECg-Vd~O=h-=b;y@!T*?14}*Y_bF8O%6txjtc?6mojjj)N5nx)BAh(8BE-O!!ElvGohhXoN7YB3!z(})v@iU+87OrQhsy1WRcj~1D ze$k3^S`?*qB72r?24DVWba>AE{mxAqZH8Dl0%ggZ(baq5OS3Y#GtZv2QjGiaBiYZ# z35lNKFRPAbT?BF1dE?~H(D4qw!#O6MOs=74e-@L&Lhf8o8Q(uCi|2@JJ<2mDeGFdp8hwf|)YDI+JTKU!Y!r7d>++ zA_rfPKDK=^_K zb{Anhdh4LDd8!!xvIR)7&4Fu1jHkQ-<+Oqhhc7dWU!{qf2+D<<>Rmu?FM44@q^~zO z2}*;I%wewNZJc1Os05h`2lcc)cg z`JYvJsTYjhALh-D%pS#_0{C_WN*fLc}(Dn;5mO$`haBL*JbHN9{@~cj0X!vL3AebC=vK=rgW#AYwkvd`#(Ww&Nj7!x17iT2xxJ-@t52Y7dhV%tJa1sqXE&9ESp&Z~5TBXmMB9oFxj21;Bs+a zjghysdiN~4uG+r)aF9Twi1iv%r_ zsr|LYfcSva?WEqq#&4NmJYF?x*M`v6Vh_W%L8MQ%VcSLs|K339Bh8rU)_{avVt`1L zHGBZWmW>edBU7cNuq*+E#yXNGF&5OOR-Ef!zP)$IOg){FKK=Y=!z@8b?jO3I_dZ_s zwCc{e{#OON#(=BC);9Wqe(Q5Z2da#+};k= zG1-%TLc{npuFovnaE}0FA^TaQo?YO4d73yVckYNf(l~oQ zpMS+Tmod}8^x)r=aXIvG=drAFo=ZR7qTM0P+^Rf}^jh(cF5>10Qe;nUJka4&A9hm1 zYFbv@_+ueV?H>JDQVw%@i9N~*)NfbGC9DOe`YkCgU&X=D@$X~=+{$iEfz!k2YwzHt zbE^eR%p)rh%=P9a6Jp>k%Poz6MzF~u(XMAKgq<6@3cc$~c`E`Z&{Z1)YlHw{CNpfjqa?oS-);KC|Fxs~E2vwQfp?;S+ z{EmJ94vrp!jZ^$Q7i|P248CUjSZ>cu!|~YE6we8mcdSii+Pmi{ z+gzq^y3BEy_3-C*WcUK+ZvjN$KH{Gbw=n!2R96+V4Tj5;RTWXe*^9UMj+m@eyhs42 zqUt*8#ut#1I(W|O?DE<6xnq0Tj>ECxp`pVUa4{+wFSkBcO5VoT^Y%Eehwgl+@g2a; z;Lwnk-H&m%n{`b=fEh{eNl@^v)(o@m^`&BXI3`QV;qQenF1Gfst7K!Tm7&K8BLPl4 z^+dcCndzmxkt2+=jImNJ(^>bs3k1IOoOM#ai>ldgX!p-}1e50}Qblet)BrO)nw0@} zqMVYhMoZJ@hXpb+M}%Ita7(Ker}Cyq_A^}Nq_MbGwW|?4J-xmsS{4kOtR-m^(?dbjBufht00iuE4-YzjD;<7WwVmmWIe+F|< z#~OUtS^bB-qdCx9fsEw&twl8RgpNj1Kh8b`J&L0A(KFg&xaiE0&qf>2v}jQVuBQW7 zGWJsfp=3>Er4LVb_gFqF;-)WSTR5nddqZ8cr;lzBbkX z5q%?9AQwCRqK@+6%ejtykirBrS|Jg5ONZi%^XRSqAmdzO8%VDh3iYvm}#=B z#F*Hpm$0;|!g(5A+@YhF(=kqx)_m^A2mv04@}w;$n+hKA=DWQ;3_-|5-)IdFf2?%u z<{@xcw8NUw`j!kcby=J#&D-Ny$O6Vice~#yfL&TuvW+-p3E5{+O;lw}y?{K9NKWFZ z-A4n6ddw_}PMIVQyX6HZKLG@-3ud&*=-{02Sd+D{}5 znQbTB4ML{wnLrROEJaTnGG^q}%fp6*Zo1B6?jjrnUCR2$X2#`b-!Zxdi3K!0iE(WC ziIknN`X}CE1yoR6ylSr1s(Pr$xE!pq$h*g!f6}M$!?Ua3(;vt)9mFB4Q=d-EJ93Wg zt5}Kwx^@(e?w5nQUF6XZ^k~~IPI+N0r^e8@s*~6;BuH5XT0_&xrWKoAY?lMgbo44+ zA1AO+q+}+y@pR0+ocOx|%FJ&p_|v7wCdst(nPZLP{?sWi+*m{683SUU>TV}m5eby+ zu9sB6T$0;Nt_=3Bo5>>GRqKgGl8gR!KzQ`c%U-Cq47~@DihHyAz$^7lW|4#F&AY@$ zRj!$35^W;*hkXo%i99x;X`V@hGKslU;P>STdnTGWgLyUp<4ohCW}^er3urY-J#Tn- zZFR<9e3;;h9A((Z0khQ~KH{uXpVV5A(Yt!mYU&ktPGS(`=G1q_`=s{fkRAB~ig3ga zlsm5VNk3u?-f1e21GsiIB}T;1sRP`juQ4ICC$|dn&$NEN1{Mb~9_9vxrC5m*@R*yA zu4grMY7?a?N>dy4)h2m^vCgP_g8b$Ln@4_Zy7ng5%nzS&9y-5qBj?II#JS%a?bF72uQ-}i{F4;a-yq|IL+yA9Kg zW!gxIjmp_zi48{FI5__LX}7_M8;rQYh#QQ!!H64-xbZ~Vcu96`TnIKU1pogR0-+kp YpD573@%!O>;3tp2Z_uf_PZ8hz3-iC^X#fBK literal 0 HcmV?d00001 From 084ab41c07b4d72221799f899beb8ef57156f8c7 Mon Sep 17 00:00:00 2001 From: Lukas Maurer Date: Mon, 16 Sep 2024 16:11:04 +0200 Subject: [PATCH 8/9] docs(faq): add mobile section (#1479) --- packages/documentation/docs/faq.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/documentation/docs/faq.md b/packages/documentation/docs/faq.md index ff73d358a9..c74be99f8a 100644 --- a/packages/documentation/docs/faq.md +++ b/packages/documentation/docs/faq.md @@ -31,6 +31,11 @@ Our design system is tailored for tablets and desktop computers, not smartphones - Large screens: >1280 pixels + +With the help of our design system, you are able to swiftly build the user interface of your mobile web app or hybrid app. +Read more on the topic in our development and UX guides on mobile development with the Industrial Experience Design System [here](/docs/mobile/mobile-app-dev). + + Our design system uses English as default, but it can be used with any language. All texts are fully customizable and therefore integrate nicely with third-party i18n solutions which means your software can easily be adapted for users of different cultures and languages. @@ -41,7 +46,7 @@ Our design system uses English as default, but it can be used with any language. We want everyone to contribute to our design system and play a part in its development. There are three main ways to contribute to or report issues: -- As a siemens employee or business partner: Post in our [Viva Engage community](https://web.yammer.com/main/groups/eyJfdHlwZSI6Ikdyb3VwIiwiaWQiOiI1ODIzNzc5NjM1MiJ9) +- As a Siemens employee or business partner: Post in our [Viva Engage community](https://web.yammer.com/main/groups/eyJfdHlwZSI6Ikdyb3VwIiwiaWQiOiI1ODIzNzc5NjM1MiJ9) - As an open-source library user: Contribute within the [Siemens Xcelerator Community](https://community.siemens.com/c/ix/30) or open tickets in [Github](https://github.com/siemens/ix) - Directly contact our team regarding larger topics: experience.industry@siemens.com For more information, see our [Github Contributing Guide](https://github.com/siemens/ix/blob/main/CONTRIBUTING.md) which has guidance on bug reporting, workflow issues and suggesting enhancements. From d17db322628605ca43004b71c3592bd80e256562 Mon Sep 17 00:00:00 2001 From: Daniel Leroux Date: Mon, 16 Sep 2024 16:23:56 +0200 Subject: [PATCH 9/9] docs(figma): add retry function after rate limit reached (#1477) --- packages/documentation/docusaurus.config.ts | 2 +- packages/figma-plugin/src/figma.ts | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/documentation/docusaurus.config.ts b/packages/documentation/docusaurus.config.ts index a7e7e68b73..749501596f 100644 --- a/packages/documentation/docusaurus.config.ts +++ b/packages/documentation/docusaurus.config.ts @@ -148,7 +148,7 @@ const config: Config = { // Please change this to your repo. editUrl: 'https://www.github.com/siemens/ix/edit/main/packages/documentation/', - remarkPlugins: useFastStart ? [] : [ + remarkPlugins: [ figmaPlugin({ baseUrl: `${baseUrl}figma`, figmaFolder: `${path.join(__dirname, 'static', 'figma')}`, diff --git a/packages/figma-plugin/src/figma.ts b/packages/figma-plugin/src/figma.ts index 71b4fe9d2d..23cc70c3d3 100644 --- a/packages/figma-plugin/src/figma.ts +++ b/packages/figma-plugin/src/figma.ts @@ -51,7 +51,15 @@ async function getImageResource( 'with node ids:', ids ); - return null; + + if (response.status === 429) { + console.log('🕰️ Retry after 60 seconds'); + return new Promise((resolve) => { + setTimeout(() => { + resolve(getImageResource(fileName, nodeIds, figmaToken)); + }, 60 * 1000); + }); + } } const data = await response.json(); @@ -150,6 +158,7 @@ async function processImage( } export default (config: FigmaConfig) => { + console.log('Figma plugin running'); if (config.apiToken === undefined || config.apiToken === '') { console.error('@siemens/figma-plugin no auth token provided'); return () => {};