Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch npm from buildchroot to schroot #469

Closed
wants to merge 3 commits into from
Closed

Switch npm from buildchroot to schroot #469

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b875e85
Update isar revision to next
WiseLord Jul 12, 2023
968355e
Add a recipe for sbuild-chroot-target-npm
WiseLord Jul 12, 2023
16bdd2a
Remove buildchroot dependency from npm.bbclass
WiseLord Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions recipes-devtools/sbuild-chroot/sbuild-chroot-target-npm.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
DESCRIPTION = "Isar sbuild/schroot filesystem for target (npm variant)"

require recipes-devtools/sbuild-chroot/sbuild-chroot-target.bb

SBUILD_FLAVOR = "npm"
SBUILD_CHROOT_PREINSTALL_EXTRA ?= "npm dpkg-dev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #433, this will need more. I wonder why you didn't check that MR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see this pull-request. Will look later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked a bit at #433. It seems to be related just to switching to derived chroot (with "npm" preintalled), while the patchset I propose is mostly about complete removing of buildchroot from npm.bbclass.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but that does not mean we should ignore what we discussed there.