Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.netcore support #2

Open
KircMax opened this issue Nov 5, 2021 · 5 comments
Open

.netcore support #2

KircMax opened this issue Nov 5, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@KircMax
Copy link
Collaborator

KircMax commented Nov 5, 2021

Having tried the RequestHandler in a .netcore app has shown that the requests haven't been sent (and responses received) as expected - we currently don't know why this is an issue.
@KircMax KircMax added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 5, 2021
@KircMax KircMax changed the title .netcore not working .netcore support Nov 5, 2021
@Stefan-J-Hanke
Copy link

Hey, I'd like to tackle this one.

I was just thinking about how to test for this behaviour. Switching the tfm from net48 to .netcoreapp3.1 did not reveal anything, tests still passing.

Hmm testing will be a challenge anyway since that would require a real or simulated PLC...

@KircMax
Copy link
Collaborator Author

KircMax commented Nov 12, 2021

Hey @Stefan-J-Hanke!
I'm happy you are interested in contributing - please read the aggreement first.

Yes - the unittests are not "harmed" when using .netcoreapp3.1 I also already noticed that.

"Real" tests (Integrationtests) will not be checked in and performed since the cicd will not be able to perform such...
In general it would be possible to test the functionality with a plcsim advanced and everything but that's nothing we want to put that much effort in currently...
So far I didn't find a way to get the problems with .netcore up using UnitTests but maybe the solution would also give a hint on how to verify .netcore support using a UnitTest - in case it doesn't I'd still be happy that it'd work on .netcore and I guess I could live with that blind spot in the unittests...

@KircMax KircMax assigned KircMax and unassigned KircMax Nov 16, 2021
@Stefan-J-Hanke
Copy link

Sorry for not responding - I'm busy atm...

Currently trying to get a PlcSim Advanced image with an activated webserver. For testing, I'll just hack something into a "unit" test (and of course not check in). My hope is that I can track down the issue and fix it.

@Stefan-J-Hanke
Copy link

OK I now have a PLCSim Adv image whose web server should be activated.

I've switched to the net6.0 tfm. It does connect however it currently is blocked by the certificate validation. The prescribed hack with setting a ServerCertificateValidationCallback does not work, the callback never gets called.

@KircMax
Copy link
Collaborator Author

KircMax commented Dec 8, 2021

Glad you are making progress @Stefan-J-Hanke ... Are you using .netcore currently? (is it possible to install the certificate that the plcsim is using?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KircMax @Stefan-J-Hanke