Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused package reference #49

Merged

Conversation

BoBoBaSs84
Copy link
Contributor

changes:

  • removed Moq from Webserver.Api.UnitTests
  • removed System.Web.Http.Common from Webserver.Api.UnitTests
  • updated System.Net.Http to be framework specific in Webserver.API

closes #48

changes:
- removed `Moq` from `Webserver.Api.UnitTests`
- removed `System.Web.Http.Common` from `Webserver.Api.UnitTests`
- updated `System.Net.Http` to be frame work specific in `Webserver.API`

closes siemens#48
Copy link
Contributor Author

@BoBoBaSs84 BoBoBaSs84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this'll do.

- unit tests failed so this is the fix for it

changes:
- `coverlet.collector` => `6.0.0`
- `NUnit3TestAdapter` => `4.5.0`
@KircMax
Copy link
Collaborator

KircMax commented Dec 18, 2023

Thanks for taking care! :)

@KircMax KircMax self-assigned this Dec 18, 2023
@KircMax KircMax merged commit 9a350cb into siemens:main Dec 18, 2023
4 checks passed
Copy link

This is addressed in release v2.2.5.

@BoBoBaSs84 BoBoBaSs84 deleted the chore/remove-unused-package-reference branch December 18, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Remove unused package reference
2 participants