Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: restrict swagger code purging to own files #42

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

michaeladler
Copy link
Member

Description

Currently everything except for the ent directory is removed. This does not scale when adding more generated code. Instead, the swagger task should only purge its own files (before recreating them).

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

Currently everything except for the `ent` directory is removed. This
does not scale when adding more generated code. Instead, the swagger
task should only purge its own files (before recreating them).

Signed-off-by: Michael Adler <[email protected]>
@michaeladler michaeladler requested a review from stormc as a code owner September 6, 2023 12:59
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #42 (4647643) into main (53a9b5f) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   77.66%   77.66%           
=======================================
  Files          79       79           
  Lines        3027     3027           
=======================================
  Hits         2351     2351           
  Misses        497      497           
  Partials      179      179           

@stormc stormc merged commit 4a30b41 into siemens:main Sep 6, 2023
@michaeladler michaeladler deleted the chore/swagger branch September 14, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants