Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CIDRBlock in Node Pools Additional Firewall Rules from string to list #46

Open
ralgozino opened this issue Jan 20, 2023 · 0 comments
Open

Change CIDRBlock in Node Pools Additional Firewall Rules from string to list #46

ralgozino opened this issue Jan 20, 2023 · 0 comments

Comments

@ralgozino
Copy link
Member

The provider support passing more than one CIDR block to the additional firewall rules of a node pool, but the installer lets you specify only one.

Change CIDRBlock in Node Pools Additional Firewall Rules from string to list:

fury-eks-installer/modules/eks/variables.tf

Line 60 in 5f3741c

cidr_block = string

Here it gets implicitly converted:

fury-eks-installer/modules/eks/ec2.tf

Line 34 in 5f3741c

cidr_blocks = [rule.cidr_block]

This is a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ralgozino