You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched searched open and closed issues for duplicates
I am submitting a bug report for existing functionality that does not work as intended
This isn't a feature request or a discussion topic
Bug description
I've noticed recent rapidly escalating memory requirements to build Signal Android from source. I used to be able to build comfortably with 16Gb RAM, then with v7.25 it started hitting swap space hard, and v7.26 required 24Gb RAM/swap. I can just build it using a standard ubuntu-latest GitHub Actions runner with the addition of an 8Gb swapfile. The peak demand for RAM seems to be during R8 minifying. The resulting APK size has hardly changed.
Would it be possible to look into what's bloating the build requirements? At least for reproducibility testing it might be ideal to target building well on a standard Github "ubuntu-latest" image?
Also, another recent upstream change I've noticed is the need for stripping the symbols from binaries of libsignal-android (v0.53.0 .. v0.54.0) and ringrtc-android (v2.48.0 .. v2.48.1), which used to be shipped as smaller stripped libraries. This means that unless the NDK is installed, the APK size is a lot bigger and not reproducible. In Signal-Android, these affected the v7.14 and v7.19 APK sizes.
Screenshots
No response
Device
No response
Android version
No response
Signal version
No response
Link to debug log
No response
The text was updated successfully, but these errors were encountered:
Guidelines
Bug description
I've noticed recent rapidly escalating memory requirements to build Signal Android from source. I used to be able to build comfortably with 16Gb RAM, then with v7.25 it started hitting swap space hard, and v7.26 required 24Gb RAM/swap. I can just build it using a standard ubuntu-latest GitHub Actions runner with the addition of an 8Gb swapfile. The peak demand for RAM seems to be during R8 minifying. The resulting APK size has hardly changed.
On Signal's end it seems the JVM max heap size was increased from 6Gb to 12Gb three weeks ago as this became apparent. Sorry I haven't bisected the exact change responsible.
Would it be possible to look into what's bloating the build requirements? At least for reproducibility testing it might be ideal to target building well on a standard Github "ubuntu-latest" image?
Also, another recent upstream change I've noticed is the need for stripping the symbols from binaries of libsignal-android (v0.53.0 .. v0.54.0) and ringrtc-android (v2.48.0 .. v2.48.1), which used to be shipped as smaller stripped libraries. This means that unless the NDK is installed, the APK size is a lot bigger and not reproducible. In Signal-Android, these affected the v7.14 and v7.19 APK sizes.
Screenshots
No response
Device
No response
Android version
No response
Signal version
No response
Link to debug log
No response
The text was updated successfully, but these errors were encountered: