Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching from sqlite to limbo #13845

Open
3 tasks done
olumolu opened this issue Dec 18, 2024 · 2 comments
Open
3 tasks done

switching from sqlite to limbo #13845

olumolu opened this issue Dec 18, 2024 · 2 comments

Comments

@olumolu
Copy link

olumolu commented Dec 18, 2024

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

https://github.com/tursodatabase/limbo
Recently there was an issue that signal crashed due to database error or something but this limbo which is fully compatible with sqlite is written in rust can be a good fit to fix those issue fully

Screenshots

No response

Device

No response

Android version

No response

Signal version

No response

Link to debug log

No response

@derekmorr
Copy link

This is premature. While limbo looks interesting, it's not clear that it would resolve the crashes (each crash needs to be assessed to see if it's caused by file corruption, bad database state, or a memory safety bug in sqlite itself). Also, limbo would need to support Android, and be supported by SQLCipher, the encryption wrapper that Signal uses for SQLite.

Limbo is something to keep an eye on in the background, but it's not ready to be used in production by Signal at this time.

@olumolu
Copy link
Author

olumolu commented Dec 18, 2024

Mainly sqlite has many issues as its test is not that open at all and many other controversy are there but what i find this limbo is actually active devlopment and almost 1:1 compatible...and mainly fully written in rust so hope there will less memory related issues so keeping extra security aside we can ensure a better product overall still i dont think limbo to be not production quality but yes it is new project.
The issue that maybe happening for some users that signal crash after opening the app which boils down to a bug in sql lite issue but not shaved down yet i think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants