Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode flash on startup #5937

Open
3 tasks done
lukasvrenner opened this issue Jan 17, 2025 · 1 comment
Open
3 tasks done

Light mode flash on startup #5937

lukasvrenner opened this issue Jan 17, 2025 · 1 comment

Comments

@lukasvrenner
Copy link

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

I have Signal set to use dark mode. On initial startup, there is a moment where the whole screen is white before it shows the Signal icon.

Steps to reproduce

  • Enable dark mode
  • Kill Signal process
  • Start Signal

Actual result: Describe here what happens after you run the steps above (i.e. the buggy behaviour)
The screen temporarily turns white.

Expected result: Describe here what should happen after you run the steps above (i.e. what would be the correct behaviour)
The screen should remain dark. It has always done so before the latest update.

Screenshots

image

Device info

Device: iPhone 11

iOS version: 18.2.1

Signal version: 7.42

Link to debug log

https://debuglogs.org/ios/7.42.0/9a53b0e66803ae831651f6fe523f792185bfa706e91059f240265317697355e9.zip

@MarlowBrown
Copy link

Hey @lukasvrenner I found the source of the bug! So Signal displays two different screens when launching the app. The first is the "Launch Screen", and the second is the "Loading Screen". That "moment" where the whole screen is white before displaying the Signal icon is the Launch Screen. The screen that (in your case since you're using dark mode) is correctly colored for dark mode is the Loading Screen.

For some reason, the Launch Screen background was missing a color value.

Missing color

Anyways, thank you for reporting the bug. The PR for the fix can be found here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants