Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Allow permissions" #5941

Open
3 tasks done
EvanHahn opened this issue Jan 21, 2025 · 4 comments
Open
3 tasks done

"Allow permissions" #5941

EvanHahn opened this issue Jan 21, 2025 · 4 comments

Comments

@EvanHahn
Copy link
Contributor

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

In the "allow permissions" registration screen, there is a strange grey bar at the top.

This is a minor visual glitch that didn't affect functionality at all as far as I could tell.

Steps to reproduce

  • Go through registration and get to the "allow permissions" screen.

Actual result: There is a grey bar at the top.

Expected result: The top should be all white, like the rest of the registration screens.

Screenshots

Screenshot

Device info

Device: iPhone 16 Plus

iOS version: 18.2.1

Signal version: 7.44 (570) (however, I may have registered on a slightly older version)

Link to debug log

N/A, I believe

@MarlowBrown
Copy link

Hey Evan!

I have a PR for this fix. That permissions view that you're looking at right now is a SwiftUI view in a hostingviewcontroller. The hostingViewController just wasn't setting the NavigationBar color correctly for light modes.

Also, on a side note, I think I remember that you are working/worked for Signal? I remember seeing your name with the "-signal" suffix that all of the other signal developers have.

@EvanHahn
Copy link
Contributor Author

@MarlowBrown Thanks for taking a look. And you're right—I don't work at Signal any more.

@MarlowBrown
Copy link

@EvanHahn Since you worked at Signal, would you mind if I emailed you tomorrow to discuss your experience there? I'm interested in the work culture, development plans, and much more!

@EvanHahn
Copy link
Contributor Author

@MarlowBrown Sure. I can't speak about development plans, but I can talk about my experience a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants