Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt light client computations when fork epoch is misaligned #7002

Open
michaelsproul opened this issue Feb 14, 2025 · 0 comments · May be fixed by #7022
Open

Do not attempt light client computations when fork epoch is misaligned #7002

michaelsproul opened this issue Feb 14, 2025 · 0 comments · May be fixed by #7022
Assignees
Labels
bug Something isn't working electra Required for the Electra/Prague fork light-client

Comments

@michaelsproul
Copy link
Member

I think we should pause light client computations if the fork epoch is misaligned in a way that breaks our calculations.

This should be necessary only for ~1 sync committee period around the fork.

It would be nice to avoid error logs, even if they are harmless, like:

Feb 13 20:25:36.228 ERRO error computing light_client updates LightClientUpdateError(BeaconStateError(IncorrectStateVariant)), service: lc_update

@michaelsproul michaelsproul added bug Something isn't working electra Required for the Electra/Prague fork light-client labels Feb 14, 2025
@eserilev eserilev self-assigned this Feb 15, 2025
@eserilev eserilev linked a pull request Feb 21, 2025 that will close this issue
@eserilev eserilev linked a pull request Feb 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working electra Required for the Electra/Prague fork light-client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants