Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to protobuf-spec 0.2.1 #528

Closed
loosebazooka opened this issue Sep 20, 2023 · 3 comments
Closed

Update to protobuf-spec 0.2.1 #528

loosebazooka opened this issue Sep 20, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone
0.6.0

Comments

@loosebazooka
Copy link
Member

-[ ] InclusionPromise (SET) is now optional if an rfc 3161 TSA issued timestamp is available
-[ ] If the certificate is currently valid, then SET and Rfc 3161 are not required to be present at verification time
-[ ] An inclusion proof in a trusted log MUST be present and verified

fyi: @haydentherapper this match up?
@loosebazooka loosebazooka added the enhancement New feature or request label Sep 20, 2023
@loosebazooka loosebazooka added this to the 0.6.0 milestone Sep 20, 2023
@haydentherapper
Copy link
Collaborator

Correct! One thing to consider is if you want to handle v0.1 bundles where the inclusion proof was not valid. I think no, require v0.2+

@loosebazooka
Copy link
Member Author

We have some bundles in public (maybe just sigstore projects on maven central). But I really think we don't care until GA.

@loosebazooka
Copy link
Member Author

fixed by #544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@loosebazooka @haydentherapper