Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid rebuilding sigstore/protobuf-specs every time #733

Open
vlsi opened this issue Jun 6, 2024 · 1 comment
Open

Avoid rebuilding sigstore/protobuf-specs every time #733

vlsi opened this issue Jun 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@vlsi
Copy link
Collaborator

vlsi commented Jun 6, 2024 •
edited
Loading

Currently, sigstore-java rebuilds sigstore/protobuf-specs every time which seems wasteful, and it makes imports like import dev.sigstore.proto. invalid on the first project import.

We should use implementation("dev.sigstore:protobuf-specs:0.3.2") rather than protobuf("dev.sigstore:protobuf-specs:0.3.2")

sigstore/protobuf-specs#341 is needed to fix this

See also:
@vlsi vlsi added the enhancement New feature or request label Jun 6, 2024
@loosebazooka
Copy link
Member

loosebazooka commented Jun 6, 2024 •
edited
Loading

I actually explicitly didn't do this because of compatibility issues. I wanted to build the protos here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vlsi @loosebazooka