Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle to 8.3 #542

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Bump Gradle to 8.3 #542

merged 1 commit into from
Oct 3, 2023

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Oct 3, 2023

Summary

Bump Gradle to 8.3

Release Note

NONE

Documentation

NONE

Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
@vlsi vlsi requested a review from loosebazooka October 3, 2023 13:29
@vlsi vlsi merged commit 6873958 into sigstore:main Oct 3, 2023
8 checks passed
Comment on lines +32 to +41
) : PublicationInternal.DerivedArtifact, Factory<File> {

// Gradle expects create(): Object method as well, otherwise it throws the following error.
// We workaround it by adding "implements Factory<File>", so Java bytecode has a bridge method
// Caused by: java.lang.AbstractMethodError: Receiver class dev.sigstore.sign.DefaultDerivedArtifactFile does not define or inherit an implementation of the resolved method 'abstract java.lang.Object create()' of interface org.gradle.internal.Factory.
// at org.gradle.api.publish.maven.internal.artifact.DerivedMavenArtifact.getFile(DerivedMavenArtifact.java:37)
// at dev.sigstore.sign.SigstoreSignExtension$sign$3.execute(SigstoreSignExtension.kt:84)
// at dev.sigstore.sign.SigstoreSignExtension$sign$3.execute(SigstoreSignExtension.kt:82)
// at org.gradle.internal.Actions$FilteredAction.execute(Actions.java:243)
// at org.gradle.internal.ImmutableActionSet$SingletonSet.execute(ImmutableAction
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljacomet , I'm not sure what is the best workaround here, however, implementing Factory<File> seem to resolve AbstractMethodError. I wonder if there's a better public API in the first place for derived artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants