drivers optimized cleanup before query execution

Don't cleanup on the newly created instance.
silverqx · Jul 26, 2024 · eba4977 · eba4977
1 parent 709ac28
commit eba4977
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/drivers/common/include_private/orm/drivers/sqlresult_p.hpp b/drivers/common/include_private/orm/drivers/sqlresult_p.hpp
@@ -64,6 +64,9 @@ namespace Orm::Drivers
         bool isActive = false;
         /*! Is this result from the SELECT statement? */
         bool isSelect = false;
+        /*! Determine if the instance needs cleanup before executing the query. It's
+            always true after the first query is executed. */
+        bool needsCleanup = false;
     };
 
 } // namespace Orm::Drivers

diff --git a/drivers/mysql/src/orm/drivers/mysql/mysqlresult.cpp b/drivers/mysql/src/orm/drivers/mysql/mysqlresult.cpp
@@ -527,6 +527,13 @@ void MySqlResult::cleanupForNormal()
 {
     Q_D(MySqlResult);
 
+    /* Helps to avoid cleanup on the newly created instance, it's only false on the newly
+       created instance. */
+    if (!d->needsCleanup) {
+        d->needsCleanup = true;
+        return;
+    }
+
     d->recordCache.clear();
 
     // Normal queries
@@ -540,6 +547,13 @@ void MySqlResult::cleanupForPrepared()
 {
     Q_D(MySqlResult);
 
+    /* Helps to avoid cleanup on the newly created instance, it's only false on the newly
+       created instance. */
+    if (!d->needsCleanup) {
+        d->needsCleanup = true;
+        return;
+    }
+
     d->recordCache.clear();
 
     // Prepared queries