Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product variation not viewable/editable by content-authors #686

Open
sparkcom opened this issue Oct 16, 2018 · 2 comments
Open

product variation not viewable/editable by content-authors #686

sparkcom opened this issue Oct 16, 2018 · 2 comments
Milestone

Comments

@sparkcom
Copy link
Contributor

the canEdit / canDelete / canCreate/canView methods need to be defined in the Variation class as content-authors can't work on variation. Currently a way to work around it is to set the permissions using an extension

@bummzack
Copy link
Collaborator

That is a general SilverStripe "issue" or limitation. DataObjects can never be edited by non-admins if permissions aren't explicitly granted.

Not sure if we should introduce explicit permissions for variations (eg. that editing of variations can be granted to a group of users), or if the permissions should just be inherited from the parent Product?
I'm leaning towards the latter approach. Thoughts?

@sparkcom
Copy link
Contributor Author

The latter approach to inherit permissions from parent Product is logical.

There is the same issue with Attribute and AttributeValue. PermissionProvider may be a good solution for them.

@wilr wilr added this to the 3.1.0 milestone Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants