Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "updateShippingPackage" for better synchronisation with shipping package #103

Open
wernerkrauss opened this issue Apr 27, 2020 · 1 comment
Open

Use "updateShippingPackage" for better synchronisation with shipping package #103

wernerkrauss opened this issue Apr 27, 2020 · 1 comment

Comments

@wernerkrauss
Copy link
Contributor

Related to silvershop/silvershop-shipping#62

The discounts module should use "updateShippingPackage", so the shipping costs can be calculated from SubTotal - Discounts.

In some cases SubTotal can mean "free shipping", but "SubTotal - Discount" is less money, so shipping costs will apply.
@RVXD
Copy link

RVXD commented Apr 29, 2020

We tried to fix it this way, but it creates an infinite loop in the calculation process. We fixed it by supplying the running total to the shipping calculator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wernerkrauss @RVXD