Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discounts pr. default applies to all orders #106

Open
thomasbnielsen opened this issue Nov 16, 2020 · 0 comments
Open

Discounts pr. default applies to all orders #106

thomasbnielsen opened this issue Nov 16, 2020 · 0 comments

Comments

@thomasbnielsen
Copy link

Hi. Just had some unexpected results on a very old SS3 installation. Basically the issue is that all discounts defaults to apply to all orders, if no constrain is found.
In this case, the client created products constraint of a list of products. These products where not translated (we use fluent), so for the locales where the constraint products where not translated, the discount got applied to all orders :-(
Not sure if this is still an issue in never versions, but if it is, i think we need some kind of "flag" like, "no constraints, applies to all orders".
Having a discount that falls-back to applying to all orders seems a bit scary.
Is this still how it works in newer versions, or has that been changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant