-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMS becomes unuseable with module installed #9
Comments
Myself and others have switched to |
I don't even bother with the module anymore. The one nice thing that it does is build all scss files from the modules (rather than having to watch each folder) but I've moved to a gruntjs based system for that as well (replacing requirements::combine_files with grunt as well) |
I use it on client projects, but not when working on SilverStripe. Just a note though: compass already checks modification times & caches the compiled css. I'm not sure how much we'd save checking timestamps outselves. We could disable the recompile on AJAX calls though, or possibly hook into Requirements::css instead of per request. |
If the called For now, I think we should remove it as a core dev dependency: silverstripe/silverstripe-installer#25 |
Agreed, and merged. |
Personally, I like this module and I think that having a way of running compass without keeping a separate daemon running in the background is a useful benefit - we have this whole requirements manager, it seems silly not to use it when SCSS is such a fundamental part of the way we do things. The barrier to entry is a higher without this module - running Once this issue is resolved, I'd like to see us include this back in the dev dependencies. This module is, in principle, a "set & forget" system for SCSS, in the same way that requirements minification is. What do you mean by "less obtrusive", Sean? |
It brings the standard admin/pages load from 1s to around 6s on my local, and adds this overhead to every ajax request in the CMS. Even for "dev mode", that's not acceptable.
And this will become more noticeable now as more people will have the module installed through
composer install --dev
(see silverstripe/silverstripe-installer@71b8b658).In the end, we should only trigger compass if relevant files are changed.
One relatively straightforward way would be to track file modification times of all *.scss files.
I haven't actually been using the module for a while now, doing
compass watch
on CLI instead.Hamish, are you still an active user?
The text was updated successfully, but these errors were encountered: