If not configured page returns empty

[LukePercy]

When configuring a CataloguePage or BrowsePage type and leaving the Catalogue Tab server URL and credentials empty, there is no handling or validation, so the page is able to be saved resulting in a blank and empty template.

Step to reproduce :-
(1) Do not configure Catalogue URL or credentials and save the page type
(2) Click on search the catalogue (enter "1" in the search box) or browser the catalogue search to return results.

==

[Notice] Trying to get property of non-objectLine.

39 and 40 in ../geocatalogue/code/commands/ParseXML2MCPCommand.php :-

$mdItem['metadataStandardName'] = $xpath->query('gmd:metadataStandardName/gco:CharacterString', $metadata)->item(0)->nodeValue;
$mdItem['metadataStandardVersion'] = $xpath->query('gmd:metadataStandardVersion/gco:CharacterString', $metadata)->item(0)->nodeValue;

[dhensby]

Thanks for taking the time to post to our issue tracker.

This repository is in the SilverStripe Archive which means it's a module we no longer actively support.

We're looking more to the community to provide support for these modules if users want to continue to use them.

Would you be willing to spend the time submitting a patch for this issue?