SS4 Migration #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilee80
commented
Feb 17, 2017
•
oilee80
commented
|
Do you believe this is ready? |
|
SS4 isn't ready for production but this works on current alpha |
|
There have been decent changes since the last alpha, so I wouldn't be testing against that. I'll set up a branch for ss4 compatibility. It would be good to get some tests so we can run travis and have some confidence there's compatibility |
|
OK - we can use master as the ss 4 compatibility branch |
Was causing circular dependency
|
Is this tested against latest master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.