Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken builds #169

Closed
GuySartorelli opened this issue Dec 3, 2023 · 1 comment
Closed

Broken builds #169

GuySartorelli opened this issue Dec 3, 2023 · 1 comment

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 3, 2023

silverstripe/userforms - 6.1 and 6

Failing behat test: https://github.com/silverstripe/silverstripe-userforms/actions/runs/7032661173

Feature: Userforms
Scenario: Operate userforms
And I press the "Save and continue" button # SilverStripe\BehatExtension\Context\BasicContext::stepIPressTheButton()
Save and continue button not found
Failed asserting that null is not null.

silverstripe/cms - 5.1 and 5

Failing PHPUnit test: https://github.com/silverstripe/silverstripe-cms/actions/runs/7010660233
Also affects CI runs for various recipes

  1. SilverStripe\CMS\Tests\Model\SiteTreeTest::testRelativeLink
    Matches URLSegment for segment = 0
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'0/'
    +'0'

This one probably just needs a Controller::normaliseTrailingSlash() call added to the expected value in the test scenario.

PRs

@GuySartorelli
Copy link
Member Author

Assigning back to steve for merge-up and to confirm broken builds are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants