Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cow does not include new modules in the changelog for their first release #231

Open
5 tasks
GuySartorelli opened this issue Dec 14, 2022 · 0 comments
Open
5 tasks
Labels

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 14, 2022

If we add a new module (e.g. if we add support for a module we previously didn't support) we currently have to add a one-off hard-coded hack to CreateChangelog.php's getChangelogLibrary() method. Otherwise, cow will skip generating the changelog for any module that wasn't in the recipe's previous release.
This caused silverstripe/developer-docs to not be included initially for the 4.12 release, which was the first time it was being included by cow.

Acceptance criteria

  • Cow automatically correctly handles modules the first time they are added to a cow release
  • For modules which have had prior versions which were not supported, the most recent tag prior to work is used as the previous version for generating the changelog
  • For modules which had no prior version at all, one of the following is used:
    • If the code was copied from another module (e.g. silverstripe/template-engine was copied from silverstripe/framework originally) the changelog shows all commits that are unique to the new repo (e.g. don't show framework commits in the docs against the template engine repo).
    • If the code is entirely new, all commits in the repo are shown in the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant