Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give page templates a fluid container, and page layouts a fixed container #4

Open
robbieaverill opened this issue Nov 1, 2017 · 0 comments
Open

Give page templates a fluid container, and page layouts a fixed container #4

robbieaverill opened this issue Nov 1, 2017 · 0 comments
Labels
affects/v4 complexity/low impact/medium type/enhancement

Comments

@robbieaverill
Copy link
Contributor

This change would not present any visual difference from the current state, but would allow developers to implement fluid containers in individual page layouts (by virtue of natural inheritance) if required.

Currently a page layout inherits a fixed container width, so to implement a fluid container you need to adjust it in the page template and then implement fixed containers in each page layout as well - adds duplication.

Fluid container (Bootstrap): class="container-fluid"
Fixed container (Bootstrap): class="container"
NightJar pushed a commit to creative-commoners/cwp-starter-theme that referenced this issue Mar 26, 2019
@MasseyIsaako
Merge pull request silverstripe#4 from silverstripe-superchargers/fea…
28223a5 
…ture/sd-8

feature/sd-8: Tidied up scss files, updated variables with bootstrap 4 variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/medium type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maxime-rainville @emteknetnz @robbieaverill @GuySartorelli