Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Create action #1

Merged
merged 2 commits into from
Jun 9, 2022
Merged

NEW Create action #1

merged 2 commits into from
Jun 9, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 30, 2022 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request May 30, 2022
Closed
23 tasks
emteknetnz
emteknetnz commented May 31, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
emteknetnz
emteknetnz commented May 31, 2022
View reviewed changes
action.yml Outdated Show resolved Hide resolved
emteknetnz
emteknetnz commented May 31, 2022
View reviewed changes
action.yml Outdated Show resolved Hide resolved
emteknetnz
emteknetnz commented May 31, 2022
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the main branch 6 times, most recently from 70a412d to f08648e Compare June 1, 2022 23:08
GuySartorelli
GuySartorelli requested changes Jun 3, 2022
View reviewed changes
action.yml Outdated Show resolved Hide resolved
.github/workflows/auto-tag.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the main branch 2 times, most recently from 98a2c87 to 3ec790f Compare June 8, 2022 02:53
GuySartorelli
GuySartorelli approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Please give me permissions necessary to merge :p

GuySartorelli
GuySartorelli requested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is one very minor formatting problem to fix. It's the only place I've seen where there's no new line before a step.

action.yml Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@GuySartorelli GuySartorelli merged commit 277edcf into silverstripe:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli