Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository owner is incorrectly identified for the simple theme #44

Closed
GuySartorelli opened this issue Apr 30, 2024 · 2 comments
Closed
Labels

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Apr 30, 2024

In https://github.com/silverstripe/silverstripe-simple/blob/3/.github/workflows/merge-up.yml we see this:
github.repository_owner == 'silverstripe-themes'
Should be github.repository_owner == 'silverstripe'

This is causing the merge-ups to not run for that repository. It's theoretically possible other repos are similarly incorrect.

@emteknetnz emteknetnz self-assigned this May 8, 2024
@emteknetnz
Copy link
Member

emteknetnz commented May 8, 2024

This will probably be resolved by #45

I've blocked this card on that issue and put this in awaiting to confirm later

@emteknetnz emteknetnz removed their assignment May 13, 2024
@GuySartorelli
Copy link
Member Author

This was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants