Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Remove unsupported modules #76

Merged
merged 1 commit into from
Nov 28, 2024
Merged

DEP Remove unsupported modules #76

merged 1 commit into from
Nov 28, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 19, 2024 •
edited
Loading

@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch 4 times, most recently from 70f7f0e to 1b7b4ad Compare November 20, 2024 05:08
@emteknetnz emteknetnz mentioned this pull request Nov 25, 2024
Closed
15 tasks
@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:32
GuySartorelli
GuySartorelli requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update .cow.json

phpunit.xml.dist Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch 2 times, most recently from ba05d2c to b6b9295 Compare November 27, 2024 00:40
GuySartorelli
GuySartorelli approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once all other PRs have been merged

GuySartorelli
GuySartorelli requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update list of behat tests in ci.yml (I was wondering why there was still red here lol)

@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch from b6b9295 to e1eff60 Compare November 28, 2024 01:43
@emteknetnz
Copy link
Member Author

Updated

GuySartorelli
GuySartorelli requested changes Nov 28, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch from e1eff60 to 5ac4e10 Compare November 28, 2024 01:58
@GuySartorelli
Copy link
Member

Userforms CI failure is a known issue and not related to this PR

GuySartorelli
GuySartorelli approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just letting the CI finish but no failures there should be related to this PR in any case.

@GuySartorelli GuySartorelli merged commit 7b58310 into silverstripe:6 Nov 28, 2024
46 of 47 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-support branch November 28, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli