Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE Identify options for a comprehensive way of creating API endpoints in the CMS #1591

Closed
maxime-rainville opened this issue Oct 1, 2023 · 5 comments
Assignees

Comments

@maxime-rainville
Copy link
Contributor

maxime-rainville commented Oct 1, 2023

Parent issue: #1589

Context

Before going to far down with #1589, we want to better understand our options, so we can split up the card in sensible ways.

Acceptance criteria

  • We've identified several options/approaches to implementing API endpoints in the CMS.
  • For each options we have pros and cons.
@emteknetnz emteknetnz self-assigned this Oct 1, 2023
@emteknetnz
Copy link
Member

emteknetnz commented Oct 5, 2023

I've done a deep dive and created a spreadsheet comparing the following API solutions:

  • Adhoc controllers
  • RestfulServer
  • GraphQL
  • REST-API (new module I've been working on)

@emteknetnz emteknetnz removed their assignment Oct 5, 2023
@emteknetnz emteknetnz removed their assignment Oct 5, 2023
@GuySartorelli GuySartorelli self-assigned this Oct 6, 2023
@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 6, 2023

I've added a few comments but on the whole this looks good as-is. Probably no changes are required as a result of my comments, which are mostly opinions, but reassigned to Steve to make that determination.
Also assigned to Max to take a look as this will likely guide the direction of various epics.

@emteknetnz emteknetnz removed their assignment Oct 6, 2023
@maxime-rainville
Copy link
Contributor Author

I only had a passing glance. So this is still very preliminary in my mind.

Honestly, it's not exactly what I had in mind. I was thinking more along the lines of "let's define a convenient place to park REST endpoints in the CMS" ... something like a slightly more evolved version of "Adhoc Controllers".

Maybe have some controller that maps to /admin/api where you can register end points. Your endpoints could be glorified extensions or some slightly more sophisticated class that implement some common pattern.

I'll have a deeper look over the next few days, but I suspect one of the outcome will be "explore a 5th or a 6th option" along what I just describe.

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 9, 2023

What you're describing sounds a lot like what Steve built.

@maxime-rainville maxime-rainville changed the title SPIKE Identify options for a comrehensive way of creating API endpoints in the CMS SPIKE Identify options for a comprehensive way of creating API endpoints in the CMS Oct 16, 2023
@maxime-rainville
Copy link
Contributor Author

maxime-rainville commented Oct 22, 2023

We've reviewed the options and have a path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants