Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ModelAdmin abstract and remove useless allowed_action declaration #1770

Open
GuySartorelli opened this issue May 30, 2024 · 0 comments
Open

Make ModelAdmin abstract and remove useless allowed_action declaration #1770

GuySartorelli opened this issue May 30, 2024 · 0 comments
Assignees
@GuySartorelli
Labels
impact/low type/api-break
Milestone
Silverstripe CMS 6.0

Comments

@GuySartorelli
Copy link
Member

There are a few small bits about ModelAdmin which aren't ideal. There are a few other issues as well, but these two are so small they weren't worth being separate from one-another.

Related

Acceptance criteria

  • Remove SearchForm from allowed_actions - this is handled by gridfield, not modeladmin
  • Make ModelAdmin abstract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
impact/low type/api-break
Projects
None yet
Milestone
Silverstripe CMS 6.0
Development

No branches or pull requests
2 participants
@jakxnz @GuySartorelli