ENH Add generic types

silverstripe · Jan 10, 2024 · e84df81 · e84df81
1 parent a144ac1
commit e84df81
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/code/Controller/AssetAdminFieldsExtension.php b/code/Controller/AssetAdminFieldsExtension.php
@@ -2,9 +2,13 @@
 
 namespace SilverStripe\AssetAdmin\Controller;
 
+use SilverStripe\Admin\LeftAndMain;
 use SilverStripe\Core\Extension;
 use SilverStripe\View\Requirements;
 
+/**
+ * @extends Extension<LeftAndMain>
+ */
 class AssetAdminFieldsExtension extends Extension
 {
     public function init()

diff --git a/code/Controller/AssetAdminFile.php b/code/Controller/AssetAdminFile.php
@@ -15,7 +15,7 @@
 /**
  * Update File dataobjects to be editable in this asset admin
  *
- * @property File $owner
+ * @extends DataExtension<File>
  */
 class AssetAdminFile extends DataExtension
 {
@@ -176,7 +176,7 @@ public function humanizedChanges($from, $to)
     /**
      * Get the list of all nested files in use
      *
-     * @return SS_List
+     * @return SS_List<File>
      */
     public function getFilesInUse()
     {

diff --git a/code/Extensions/CampaignAdminExtension.php b/code/Extensions/CampaignAdminExtension.php
@@ -2,6 +2,7 @@
 
 namespace SilverStripe\AssetAdmin\Extensions;
 
+use SilverStripe\AssetAdmin\Forms\FileFormFactory;
 use SilverStripe\Assets\File;
 use SilverStripe\Core\Extension;
 use SilverStripe\Forms\FormAction;
@@ -10,7 +11,8 @@
 /**
  * Extension that updates the Popover menu of `FileFormFactory`.
  * This extension will only be applied if the `campaign-admin` module is installed.
- * @package SilverStripe\AssetAdmin\Extensions
+ *
+ * @extends Extension<FileFormFactory>
  */
 class CampaignAdminExtension extends Extension
 {

diff --git a/code/Extensions/RemoteFileModalExtension.php b/code/Extensions/RemoteFileModalExtension.php
@@ -20,7 +20,8 @@
 
 /**
  * Decorates ModalController with an insert-oembed modal
- * @see ModalController
+ *
+ * @extends Extension<ModalController>
  */
 class RemoteFileModalExtension extends Extension
 {
@@ -30,16 +31,6 @@ class RemoteFileModalExtension extends Extension
         'remoteEditFormSchema',
     );
 
-    /**
-     * @return ModalController
-     */
-    public function getOwner()
-    {
-        /** @var ModalController $owner */
-        $owner = $this->owner;
-        return $owner;
-    }
-
     /**
      * @return HTTPRequest
      */

diff --git a/code/Extensions/UsedOnTableExtension.php b/code/Extensions/UsedOnTableExtension.php
@@ -2,6 +2,7 @@
 
 namespace SilverStripe\AssetAdmin\Extensions;
 
+use SilverStripe\Admin\Forms\UsedOnTable;
 use SilverStripe\Assets\Folder;
 use SilverStripe\Assets\Shortcodes\FileLink;
 use SilverStripe\Core\Extension;
@@ -10,6 +11,8 @@
 
 /**
  * Hides several types of DataObjects on the "Used On" tab when viewing files
+ *
+ * @extends Extension<UsedOnTable>
  */
 class UsedOnTableExtension extends Extension
 {