-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error message when adding large files are not readable #895
Comments
I think this component lives in |
Ha, true. I don't want to move it again though =D |
The confirmation messages don't work too well there in small screen widths. Update uploadfield design to accommodate longer messages
|
Yeah it seems to just dump the response of the validation request verbatim. In your case it's obviously receiving some HTML page that it's dumping the source of 😞 . |
I suspect that #925 is the reason that @clarkepaul is seeing HTML instead of a friendly error message |
Note that the escaped HTML part of this is tracked here: #915 This issue should just address the fact that a message like "Filesize is too large" isn't able to be rendered. I believe someone made a PR that would show the full message as a title/hover tooltip, which is an improvement and might be enough to close this issue. |
Noting that this issue has been updated to include some new ACs. @silverstripeux noted that they want to have another look at the designs to check everything is in order |
Updated designs can be found here: Silverstripe CMS Design System Few notes:
Let me know if you have any thoughts or feedback 🙂 |
@sachajudd DSM link isn't working for me, I've tried logging in an out. Not sure what's going on Could you take a screenshot of the design and post it here as a comment? |
Sorted with @emteknetnz offline. Link is working correctly. |
Looks like this was indirectly fixed by #1138 This is how it now renders: @brynwhyman you happy to close this? |
@emteknetnz the screenshot in the description looks to have a reduced-width. Have you tested that also? I'm guessing that the messaging still won't be as responsive as we want it to be. When we looked at this issue, we felt that new designs would be the best way to solve the high-level bug that is: 'the error message is not readable'. I wouldn't expect to close this issue until the following AC is met:
|
Agree with @brynwhyman to leave open until the new design direction has been followed. |
Originally from silverstripe/silverstripe-elemental-fileblock#9
Reproduce
silverstripe/elemental-fileblock
on2.x-dev
anddnadesign/silverstripe-elemental
on4.x-dev
Browse
link to add a file that is 2MB+Acceptance criteria
Design notes
The text was updated successfully, but these errors were encountered: