ValidationResult::addError() doesn't show up anywhere in the UI

[robbieaverill]

Version: 4.4.x-dev

Steps to reproduce

Add this to Image:

    public function validate()
    {
        $validation = parent::validate();
        if ($this->isInDB() && empty($this->Title)) {
            $validation->addError('Testing error');
        }
        return $validation;
    }

Upload an image. This is successful (as expected) because the isInDB() check skips validation.

Open the image and remove the title, then try to save the image.

Expected result

The image should not save. I should see "Testing error" somewhere in an error alert.

Result

The image doesn't save (correct). No validation error is shown in the UI (bug).

---

This works with $validation->addFieldError('Title', 'Testing error'):

PRs

• Allows display of validation messages on assets #1377 (for new files only - doesn't address editing existing files)
• FIX Validation error message with ValidationResult::addError silverstripe-admin#1587

[blueo]

Just ran into something similar - seems to related to the changes here: #1138 . In my case the validation message isn't showing on an uploaded file thumbnail.

[blueo]

So it appears since 4.6 validation errors that are not attached to a field will not be displayed anywhere. As per the above description the Edit form will not display anything from addError but now we also don't get a validation message in the Thumbnail view:
eg with the following validation code on Image:

$result->addError('The image already exists (' . $location . ')');

before 4.6 the thumbnail displays the validation error:

after 4.6 the thumbnail has a generic error:

I feel we need to find a home/better way of displaying these general errors in the admin

[blueo]

@emteknetnz FYI I think there is still an outstanding issue when 'addError' is called on an existing asset - so its only partially closed... @GuySartorelli has some context

[GuySartorelli]

Reopening this. As per the note in the issue description, this has only been resolved for new files, but is still a problem for existing files.

[GuySartorelli]

Fixed in silverstripe/silverstripe-admin#1587.
This will be automatically tagged by GitHub Actions.