Table view doesn't show modified files in list

[albanyacademy]

Latest SS version.

Table view:

Tile view:

Missing that orange circle on table view indicating modified/draft files.

Pulls request

(Merge in this order)

• API Add reference to new VersionedBadge component webpack-config#37
• NEW Add VersionedBadge for displaying versioning states in the CMS silverstripe-admin#861
• BUG Add a status column to the table view silverstripe-asset-admin#980

[newleeland]

Potential design

When sorting by status:

• Default sort order: Folders, Draft, Modified, Published.
• Sorted: Folders, Published, Modified, Draft.

[maxime-rainville]

@newleeland @clarkepaul Do you mind if we make the column unsortable? Sorting by status is not something Versioned support out of the box, it could be tricky to implement. If you want it, it probably needs to be a separate card.

[albanyacademy]

Why not just apply it to the icon, same as it is on tile view? Considering the other columns are sortable it would make more sense to just carry over the treatment that already exists in tile view, for consistency's sake - then you're also not implying that it's a sortable value.

…

On Wed, Aug 28, 2019 at 10:31 PM Maxime Rainville ***@***.***> wrote: @newleeland <https://github.com/newleeland> @clarkepaul <https://github.com/clarkepaul> Do you mind if we make the column unsortable? Sorting by status is not something Versioned support out of the box, it could be tricky to implement. If you want it, it probably needs to be a separate card. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#286?email_source=notifications&email_token=ABFW3OQU2WS4ZXQGCEKPFSDQG5NMHA5CNFSM4HTAIURKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5NJG4I#issuecomment-526029681>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFW3OWAAGIBB3WQF672LSLQG5NMHANCNFSM4HTAIURA> .

-- Yrs., Cameron R. Lindsay

[clarkepaul]

We could add a filter for status at a later stage so fine that it isn't sortable here. In the UI it shows quite clearly which columns are sortable and not with arrows e.g. size is not sortable for some reason.

@newleeland with them not being sortable, which way do you prefer? (icon or text).

[maxime-rainville]

I've implemented it as a column. Here's what it looks like https://youtu.be/i96_f7JvzOs

Is our collective wisdom that sorting by size should be possible?

[clarkepaul]

@maxime-rainville if its easy to add, yes please.

[newleeland]

I think that table view is good as it more obvious! bummer we can't do sort for this story. I can see issues with us having it in the image as a dot here:

• Dot will cover alot of the image as image is smaller
• Dot harder to see on image as a lot of detail would be cramped together
• Tricky to position do in the same spot of images as aspect ratios vary

[maxime-rainville]

@clarkepaul Just had a look, we don't actually tracked the size of files in the DB. We read it from the physical file each time we need to display it.

This makes it impractical to sort by size. I'll create a separate issue for storing the File size in the DB to make sorting by size easier.

[maxime-rainville]

I created to track the file size sorting silverstripe/silverstripe-asset-admin#996

[maxime-rainville]

Fixed by silverstripe/silverstripe-asset-admin#980