Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to revert/unrelease the campaign #43

Open
newleeland opened this issue Aug 14, 2017 · 3 comments
Open

Add ability to revert/unrelease the campaign #43

newleeland opened this issue Aug 14, 2017 · 3 comments

Comments

@newleeland
Copy link

newleeland commented Aug 14, 2017

Currently, when a user publishes a campaign by accident, they don't have the ability revert the pages and files that were just published to their previous states.

Even without the ability to revert back, users also can't easily undo the changes manually as they don't have the ability to see what was released.

It does appear we do have a revert button (disable) positioned in Campaigns already, however,
the listing disappears once the campaigns section is refreshed. This doesn't seem to be in the backlog. Resolves: #38

screen_shot_2017-08-15_at_10_42_34_am

There are several directions we can take this. As there is an issue where if a campaign needed to be reverted back, however, if another newer campaign has made changes to pages within this campaign, there will be some conflict on what is reverted back.

  • We can revert back only there are not overlapping campaign released after it.
  • We allow the user to revert all the way back, even if new changes have been added outside the campaign. This will require notifying the user, of overwriting changes made outside of this campaign. (This is not ideal however it will allow the user to revert quickly).
  • Have a listing of all released campaigns so that one could go back make alterations manually.
@chillu
Copy link
Member

chillu commented Aug 21, 2017

Given there's a workaround for this already for most use cases (revert included pages individually through standard CMS means), I'm going to downprioritise this. Given the complexities you mention on a complete revert of a campaign, I think most people would feel more comfortable "rolling forward" and just fix what needs fixing through individual publish actions. Let's see how/if campaigns are used before adding these kinds of features. Removing milestone.

@chillu chillu removed this from the Recipe 4.0.0-beta3 milestone Aug 21, 2017
@chillu
Copy link
Member

chillu commented Aug 24, 2017

We've discussed the ability to publish the same campaign multiple times over at #38, which turns out to complicate the "revert" feature. Since items in a changeset only track one set of "before/after" version, they'd either have to keep inaccurate info about the last publish action, or revert only the last publish - neither of which seems entirely practical.

I'm suggesting that we allow authors to duplicate an (already published) campaign if their use case demands repeat publish of the same set of items. That duplicate would need to be smart enough to set new before/after versions

@sminnee
Copy link
Member

sminnee commented Aug 24, 2017

One way to simplify this might be to disable the "undo publish" feature if any of the the pages in the campaign has subsequently been published.

This would let us provide a "oops I didn't mean to click the button" feature without needing to implement git under the hood. ;-)

A companion feature for single-page-publishes would make sense too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants