Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content in New, Spam and Approved tabs doesn't update after XHR requests #225

Open
robbieaverill opened this issue Dec 18, 2017 · 2 comments

Comments

@robbieaverill
Copy link
Contributor

robbieaverill commented Dec 18, 2017

SS 4.1

If I go to the "Approved" tab and click to mark one of the items in the GridField as spam then the pane reloads, but the GridField contents within each tab are unchanged. This means that when you "spam" or "approve" a set of comments that they disappear until you reload the window, in which case they're in the correct GridField again.

Note: issue has changed, updated the original

Example - three comments that are "spam":

image

Select one and set as approved:

image

While the original record has disappeared from the "spam" GridField, it doesn't show up under Approved yet:

image

Also note that the count of comments in the tab titles haven't updated either, but this is a pre-existing issue which is already logged as #188

@robbieaverill robbieaverill changed the title New, Approved, Spam tabs lose their click handlers after XHR requests Content in New, Spam and Approved tabs doesn't update after XHR requests Feb 26, 2018
@raissanorth
Copy link
Contributor

This issue also affects SilverStripe 3. I have reproduced it using silverstripe/comments 2.1.6, colymba/gridfield-bulk-editing-tools v2.1.10, and silverstripe/framework 3.6.5.

@siteleas
Copy link

This problem persists in 4.3. You still have to refresh the page to update the grids on the different tabs. So, marking a comment as spam causes it to disappear from the approved comments list but it doesn't show up on the spam tab until you refresh the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@siteleas @emteknetnz @robbieaverill @raissanorth and others