Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content is saved plaintext into cookies. #279

Open
caffeineinc opened this issue Mar 13, 2019 · 1 comment
Open

Content is saved plaintext into cookies. #279

caffeineinc opened this issue Mar 13, 2019 · 1 comment

Comments

@caffeineinc
Copy link

This was originally picked up by a pen test report, that although it's not exploitable, any SQL injection code is added to the content of a comment is stored in a cookie and sent in the browser headers.

I don't think you could pivot from this to something exploitable but it's probably not a great idea to send this via cookie back to the client.

I don't see much in terms of benefit in using cookie over session, but i do have a fix -

If someone thinks it will be beneficial, i can create a PR -

caffeineinc@747d4f4

@NightJar
Copy link
Contributor

PR Please @caffeineinc :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants